github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 09:06:13 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6719] [MERGED] [PM-34124] refactor: Generalize CameraPreview analyzer parameter #55032

New Issue
Closed
opened 2026-05-01 20:57:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:57:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6719
Author: @SaintPatrck
Created: 3/25/2026
Status: ✅ Merged
Merged: 4/6/2026
Merged by: @SaintPatrck

Base: main ← Head: card-scanner/1-generalize-camera-preview

📝 Commits (1)

  • c04ac3b [PM-34124] refactor: Generalize CameraPreview analyzer parameter

📊 Changes

3 files changed (+8 additions, -9 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt (+1 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt (+1 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/camera/CameraPreview.kt (+6 -7)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34124

📔 Objective

Generalizes the CameraPreview composable to accept any ImageAnalysis.Analyzer instead of the QR-code-specific QrCodeAnalyzer. This prepares the component for reuse by the upcoming card scanner feature while maintaining full backward compatibility with existing QR code scanning call sites.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6719 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/25/2026 **Status:** ✅ Merged **Merged:** 4/6/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `card-scanner/1-generalize-camera-preview` --- ### 📝 Commits (1) - [`c04ac3b`](https://github.com/bitwarden/android/commit/c04ac3b4fc2a9de9931e68137fbf5144aa8633a1) [PM-34124] refactor: Generalize CameraPreview analyzer parameter ### 📊 Changes **3 files changed** (+8 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt` (+1 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt` (+1 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/camera/CameraPreview.kt` (+6 -7) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-34124 ## 📔 Objective Generalizes the `CameraPreview` composable to accept any `ImageAnalysis.Analyzer` instead of the QR-code-specific `QrCodeAnalyzer`. This prepares the component for reuse by the upcoming card scanner feature while maintaining full backward compatibility with existing QR code scanning call sites. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:57:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55032
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?