github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6608] [MERGED] Move FakeLifecycle to core module #54931

New Issue
Closed
opened 2026-05-01 20:47:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:47:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6608
Author: @david-livefront
Created: 3/2/2026
Status: ✅ Merged
Merged: 3/2/2026
Merged by: @david-livefront

Base: main ← Head: common-fake-lifecycle

📝 Commits (1)

  • 2f03017 Move FakeLifecycle to core module

📊 Changes

9 files changed (+7 additions, -60 deletions)

View changed files

📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/AppStateManagerTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerTest.kt (+1 -1)
📝 authenticatorbridge/build.gradle.kts (+1 -0)
📝 authenticatorbridge/src/test/kotlin/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerTest.kt (+1 -1)
➖ authenticatorbridge/src/test/kotlin/com/bitwarden/authenticatorbridge/util/FakeLifecycle.kt (+0 -45)
➖ authenticatorbridge/src/test/kotlin/com/bitwarden/authenticatorbridge/util/FakeLifecycleOwner.kt (+0 -10)
📝 core/build.gradle.kts (+1 -0)
📝 core/src/testFixtures/kotlin/com/bitwarden/core/data/util/FakeLifecycle.kt (+1 -1)
📝 core/src/testFixtures/kotlin/com/bitwarden/core/data/util/FakeLifecycleOwner.kt (+1 -1)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR moves the FakeLifecycle and FakeLifecycleOwner to the core module so it can be shared across all tests that need it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6608 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/2/2026 **Status:** ✅ Merged **Merged:** 3/2/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `common-fake-lifecycle` --- ### 📝 Commits (1) - [`2f03017`](https://github.com/bitwarden/android/commit/2f03017170bd461b4f8d6bf7198cd5f54cba593e) Move FakeLifecycle to core module ### 📊 Changes **9 files changed** (+7 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/AppStateManagerTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerTest.kt` (+1 -1) 📝 `authenticatorbridge/build.gradle.kts` (+1 -0) 📝 `authenticatorbridge/src/test/kotlin/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerTest.kt` (+1 -1) ➖ `authenticatorbridge/src/test/kotlin/com/bitwarden/authenticatorbridge/util/FakeLifecycle.kt` (+0 -45) ➖ `authenticatorbridge/src/test/kotlin/com/bitwarden/authenticatorbridge/util/FakeLifecycleOwner.kt` (+0 -10) 📝 `core/build.gradle.kts` (+1 -0) 📝 `core/src/testFixtures/kotlin/com/bitwarden/core/data/util/FakeLifecycle.kt` (+1 -1) 📝 `core/src/testFixtures/kotlin/com/bitwarden/core/data/util/FakeLifecycleOwner.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR moves the `FakeLifecycle` and `FakeLifecycleOwner` to the `core` module so it can be shared across all tests that need it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:47:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54931
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?