github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6554] [MERGED] Replace ZonedDateTime with Instant #54886

New Issue
Closed
opened 2026-05-01 20:41:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:41:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6554
Author: @david-livefront
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @david-livefront

Base: main ← Head: replace-zoned-date-time

📝 Commits (1)

  • 13b18e8 Replace ZonedDateTime with Instant

📊 Changes

112 files changed (+566 additions, -680 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/AccountJson.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthRequestManagerImpl.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/model/AuthRequest.kt (+3 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/PushDiskSource.kt (+3 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/PushDiskSourceImpl.kt (+7 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/database/PlatformDatabase.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/di/PlatformDiskModule.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/entity/OrganizationEventEntity.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt (+2 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerImpl.kt (+1 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/NotificationPayload.kt (+5 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SyncCipherUpsertData.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SyncFolderUpsertData.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SyncSendUpsertData.kt (+2 -2)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/convertor/InstantTypeConverter.kt (+27 -0)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/convertor/ZonedDateTimeTypeConverter.kt (+0 -31)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/database/VaultDatabase.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/di/VaultDiskModule.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/entity/FolderEntity.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt (+1 -1)

...and 80 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR replaces the usage of ZonedDateTime with Instant. All the dates in the app are in UTC already and the Bitwarden SDK uses Instant as well. This should simplify logic within the app and remove the need to convert class types when interacting with the SDK.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6554 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `replace-zoned-date-time` --- ### 📝 Commits (1) - [`13b18e8`](https://github.com/bitwarden/android/commit/13b18e82a0c5b3f88da5f70b535282abd3fee990) Replace ZonedDateTime with Instant ### 📊 Changes **112 files changed** (+566 additions, -680 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/datasource/disk/model/AccountJson.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthRequestManagerImpl.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/model/AuthRequest.kt` (+3 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/PushDiskSource.kt` (+3 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/PushDiskSourceImpl.kt` (+7 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/database/PlatformDatabase.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/di/PlatformDiskModule.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/entity/OrganizationEventEntity.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt` (+2 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerImpl.kt` (+1 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/NotificationPayload.kt` (+5 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SyncCipherUpsertData.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SyncFolderUpsertData.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SyncSendUpsertData.kt` (+2 -2) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/convertor/InstantTypeConverter.kt` (+27 -0) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/convertor/ZonedDateTimeTypeConverter.kt` (+0 -31) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/database/VaultDatabase.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/di/VaultDiskModule.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/entity/FolderEntity.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt` (+1 -1) _...and 80 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR replaces the usage of `ZonedDateTime` with `Instant`. All the dates in the app are in UTC already and the Bitwarden SDK uses Instant as well. This should simplify logic within the app and remove the need to convert class types when interacting with the SDK. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:41:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?