github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6535] [MERGED] [PM-32149] Send email verification error dialogs #54869

New Issue
Closed
opened 2026-05-01 20:39:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:39:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6535
Author: @aj-rosado
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @aj-rosado

Base: main ← Head: PM-32149/send-email-verification-error-dialogs

📝 Commits (10+)

  • b6b7002 Added new UI for the Email verification on sends
  • 5dd79bf Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • bc3b881 Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • 107ac9f addressed PR comments
  • 9b0b6af Addressed missing ImmutableList calls and fixed tests
  • c91306b Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • b3053e4 fixed SyncServiceTest
  • c813498 Revert "fixed SyncServiceTest"
  • 8917a9f Changed SendAuthType's SupportingTextRes property to Text
  • 1475416 Added error dialogs for empty or invalid emails

📊 Changes

3 files changed (+99 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModel.kt (+35 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModelTest.kt (+60 -0)
📝 ui/src/main/res/values/strings.xml (+4 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32149

📔 Objective

Add validation dialogs on invalid or empty emails

📸 Screenshots

Empty email addresses error dialog Invalid email addresses error dialog

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6535 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-32149/send-email-verification-error-dialogs` --- ### 📝 Commits (10+) - [`b6b7002`](https://github.com/bitwarden/android/commit/b6b70024c3e5a66a56f1f05baf42bb21a0b2e9be) Added new UI for the Email verification on sends - [`5dd79bf`](https://github.com/bitwarden/android/commit/5dd79bf2bc25911cad9a098651da509c055fc006) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`bc3b881`](https://github.com/bitwarden/android/commit/bc3b881830a97f7ea71232e1cc4692b063a5f27e) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`107ac9f`](https://github.com/bitwarden/android/commit/107ac9f3ca92db15ac91ac3bb67bee0c50dce42d) addressed PR comments - [`9b0b6af`](https://github.com/bitwarden/android/commit/9b0b6afbaff1dba03f3815783587bb8de85a4053) Addressed missing ImmutableList calls and fixed tests - [`c91306b`](https://github.com/bitwarden/android/commit/c91306b0f6502d92d515aad247c78579eec1046c) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`b3053e4`](https://github.com/bitwarden/android/commit/b3053e48d2cedced9f1fa0db861901ee456004f5) fixed SyncServiceTest - [`c813498`](https://github.com/bitwarden/android/commit/c813498484932e2c50c78e5581d23d73aa27fd3f) Revert "fixed SyncServiceTest" - [`8917a9f`](https://github.com/bitwarden/android/commit/8917a9f22c1faa82b16eb0b0bdeab7441b61b403) Changed SendAuthType's SupportingTextRes property to Text - [`1475416`](https://github.com/bitwarden/android/commit/1475416d097469ddd854d696ed69d14ea31c3170) Added error dialogs for empty or invalid emails ### 📊 Changes **3 files changed** (+99 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModel.kt` (+35 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModelTest.kt` (+60 -0) 📝 `ui/src/main/res/values/strings.xml` (+4 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-32149 ## 📔 Objective Add validation dialogs on invalid or empty emails ## 📸 Screenshots <img width="360" alt="Empty email addresses error dialog" src="https://github.com/user-attachments/assets/dd247a9d-eff2-4f47-b0f2-7d013a832e2f" /> <img width="360" alt="Invalid email addresses error dialog" src="https://github.com/user-attachments/assets/bc42eabd-12ee-49fa-a30f-99176af99a15" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:39:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54869
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?