github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6424] [MERGED] Add comprehensive tests for AuthenticatorRepositoryImpl #54787

New Issue
Closed
opened 2026-05-01 20:31:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:31:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6424
Author: @SaintPatrck
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/30/2026
Merged by: @SaintPatrck

Base: main ← Head: test/critical/authenticator-repository

📝 Commits (4)

  • 643792c Add comprehensive tests for AuthenticatorRepositoryImpl
  • 0066df9 Remove initial state test
  • ea358b5 Comments
  • a6d2a37 Refactor AuthenticatorRepositoryTest to remove redundant exception tests

📊 Changes

2 files changed (+251 additions, -13 deletions)

View changed files

📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/datasource/disk/util/FakeAuthenticatorDiskSource.kt (+4 -2)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryTest.kt (+247 -11)

📄 Description

🎟️ Tracking

Test coverage improvements for critical authenticator repository functionality.

📔 Objective

This PR enhances test coverage for AuthenticatorRepositoryImpl, a critical component responsible for managing authenticator data persistence and retrieval in the Authenticator application.

Changes:

  • Comprehensive test suite additions for AuthenticatorRepositoryImpl
  • Cleanup of unnecessary test utilities in FakeAuthenticatorDiskSource
  • Full validation of repository CRUD operations, Flow emissions, and error handling
  • Edge case testing for concurrent operations and state management

The repository layer serves as the primary data access abstraction for authenticator items. These tests ensure data integrity, proper Flow behavior, and correct error propagation throughout the data layer.

📸 Screenshots

N/A - Test-only changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6424 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/30/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `test/critical/authenticator-repository` --- ### 📝 Commits (4) - [`643792c`](https://github.com/bitwarden/android/commit/643792cdce5a9e73d37cbcf1d6ae8dc7a33d51ff) Add comprehensive tests for AuthenticatorRepositoryImpl - [`0066df9`](https://github.com/bitwarden/android/commit/0066df9c6b52c638c5748c74d2453feb82622a47) Remove initial state test - [`ea358b5`](https://github.com/bitwarden/android/commit/ea358b5c4a3558a8270e437e6c2ae0365fce6e41) Comments - [`a6d2a37`](https://github.com/bitwarden/android/commit/a6d2a37ecaab377a7c4f422917852d0778297f05) Refactor AuthenticatorRepositoryTest to remove redundant exception tests ### 📊 Changes **2 files changed** (+251 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/datasource/disk/util/FakeAuthenticatorDiskSource.kt` (+4 -2) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryTest.kt` (+247 -11) </details> ### 📄 Description ## 🎟️ Tracking Test coverage improvements for critical authenticator repository functionality. ## 📔 Objective This PR enhances test coverage for `AuthenticatorRepositoryImpl`, a critical component responsible for managing authenticator data persistence and retrieval in the Authenticator application. **Changes:** - Comprehensive test suite additions for `AuthenticatorRepositoryImpl` - Cleanup of unnecessary test utilities in `FakeAuthenticatorDiskSource` - Full validation of repository CRUD operations, Flow emissions, and error handling - Edge case testing for concurrent operations and state management The repository layer serves as the primary data access abstraction for authenticator items. These tests ensure data integrity, proper Flow behavior, and correct error propagation throughout the data layer. ## 📸 Screenshots N/A - Test-only changes ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:31:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54787
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?