github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5097] [MERGED] chore/SRE-583 Deprecate usage of Auth-Email Header #5477

New Issue
Closed
opened 2025-11-27 00:03:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:03:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5097
Author: @bitwarden-charlie
Created: 4/25/2025
Status: ✅ Merged
Merged: 8/18/2025
Merged by: @sneakernuts

Base: main ← Head: chore/SRE-583-Deprecate-usage-of-Auth-Email-Header

📝 Commits (10+)

  • 38ed509 chore/SRE-583 Deprecate usage of Auth-Email Header
  • 3baa89b removed authEmail from IdentityServiceImpl
  • f4683bb Removed import for base64UrlEncode
  • ec2f2bd Merge branch 'main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header
  • d2b26d6 removing import for base64UrlEncode
  • a38b0bf removed import for Header
  • 04d7075 Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header
  • 380085b Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header
  • 6977339 Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header
  • fea0150 Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header

📊 Changes

2 files changed (+0 additions, -4 deletions)

View changed files

📝 network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedIdentityApi.kt (+0 -2)
📝 network/src/main/kotlin/com/bitwarden/network/service/IdentityServiceImpl.kt (+0 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-583

📔 Objective

Deprecate usage of Auth-Email Header

Server side changes: https://github.com/bitwarden/server/pull/5709

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5097 **Author:** [@bitwarden-charlie](https://github.com/bitwarden-charlie) **Created:** 4/25/2025 **Status:** ✅ Merged **Merged:** 8/18/2025 **Merged by:** [@sneakernuts](https://github.com/sneakernuts) **Base:** `main` ← **Head:** `chore/SRE-583-Deprecate-usage-of-Auth-Email-Header` --- ### 📝 Commits (10+) - [`38ed509`](https://github.com/bitwarden/android/commit/38ed50990604d6174b292be929c4d31b9f27066d) chore/SRE-583 Deprecate usage of Auth-Email Header - [`3baa89b`](https://github.com/bitwarden/android/commit/3baa89beb848137143249a03095b492c450e7ef4) removed authEmail from IdentityServiceImpl - [`f4683bb`](https://github.com/bitwarden/android/commit/f4683bb49639ff34f3743744d0ecbb7e57d0d131) Removed import for base64UrlEncode - [`ec2f2bd`](https://github.com/bitwarden/android/commit/ec2f2bd77133a09a198f363ed9cc08c5798bb2de) Merge branch 'main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header - [`d2b26d6`](https://github.com/bitwarden/android/commit/d2b26d692567090644737fab748b6ff2d91c5b1e) removing import for base64UrlEncode - [`a38b0bf`](https://github.com/bitwarden/android/commit/a38b0bf522c66ad9c3e7387a68127e1a03cd9e66) removed import for Header - [`04d7075`](https://github.com/bitwarden/android/commit/04d70753b5f482e3bb3cab3d9a3773b9122ffa1b) Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header - [`380085b`](https://github.com/bitwarden/android/commit/380085b6e8731feff495e6968ed4aaaef6d8d5a6) Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header - [`6977339`](https://github.com/bitwarden/android/commit/6977339cc4caa33a58f6e2dfae1a7493a13b5b19) Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header - [`fea0150`](https://github.com/bitwarden/android/commit/fea01505548b0940c6c548c8214117a3023222fb) Merge remote-tracking branch 'origin/main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-Header ### 📊 Changes **2 files changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedIdentityApi.kt` (+0 -2) 📝 `network/src/main/kotlin/com/bitwarden/network/service/IdentityServiceImpl.kt` (+0 -2) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/SRE-583 ## 📔 Objective Deprecate usage of Auth-Email Header Server side changes: https://github.com/bitwarden/server/pull/5709 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:03:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?