github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-05 23:38:51 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6400] [MERGED] [PM-14880] ci: Address automated PR labeling workflow feedback #54768

New Issue
Closed
opened 2026-05-01 20:29:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:29:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6400
Author: @vvolkgang
Created: 1/22/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @vvolkgang

Base: main ← Head: vvolkgang/label-pr-improvements

📝 Commits (5)

  • 62dc0d9 Check for all bots
  • 5a93540 Using replace mode, preserve existing labels that aren't app: or t:
  • 94e8750 Update workflow name and run-name
  • 949ad6d Stop adding a catch all label
  • b04a222 Update script doc

📊 Changes

3 files changed (+50 additions, -19 deletions)

View changed files

📝 .github/label-pr.json (+0 -1)
📝 .github/scripts/label-pr.py (+38 -13)
📝 .github/workflows/sdlc-label-pr.yml (+12 -5)

📄 Description

🎟️ Tracking

PM-14880

📔 Objective

Address automated PR labeling workflow feedback to better handle existing labels and bot detection:

  1. In replace mode, preserve existing labels that aren't app: or t: - ai-review should now be preserved.
  2. Enhance manual label process by not adding a generic catch-all label
  3. Improve bot detection, should detect all bots and apps - app/ prefix is used when workflow is manually triggered (workflow_dispatch).
  4. Improve workflow name / run-name, making it easier to identify runs

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6400 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 1/22/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `vvolkgang/label-pr-improvements` --- ### 📝 Commits (5) - [`62dc0d9`](https://github.com/bitwarden/android/commit/62dc0d93b59ddaa84503d2cae2c5c328b664c17c) Check for all bots - [`5a93540`](https://github.com/bitwarden/android/commit/5a93540a1f2f8dde7ff0f57056df2fdd68db1195) Using replace mode, preserve existing labels that aren't app: or t: - [`94e8750`](https://github.com/bitwarden/android/commit/94e875083470c7f4e3f48c81f9c369f1e4cd27cd) Update workflow name and run-name - [`949ad6d`](https://github.com/bitwarden/android/commit/949ad6d9adafdc6b149a3a6dc387989eb6bdff05) Stop adding a catch all label - [`b04a222`](https://github.com/bitwarden/android/commit/b04a222a853e20b07d59b8e96ff72184408054ec) Update script doc ### 📊 Changes **3 files changed** (+50 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/label-pr.json` (+0 -1) 📝 `.github/scripts/label-pr.py` (+38 -13) 📝 `.github/workflows/sdlc-label-pr.yml` (+12 -5) </details> ### 📄 Description ## 🎟️ Tracking PM-14880 ## 📔 Objective Address automated PR labeling workflow feedback to better handle existing labels and bot detection: 1. In `replace` mode, preserve existing labels that aren't `app:` or `t:` - `ai-review` should now be preserved. 1. Enhance manual label process by not adding a generic catch-all label 1. Improve bot detection, should detect all bots and apps - `app/` prefix is used when workflow is manually triggered (`workflow_dispatch`). 1. Improve workflow name / run-name, making it easier to identify runs ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:29:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54768
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?