github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6369] [MERGED] PM-29694: Update archive empty state #54743

New Issue
Closed
opened 2026-05-01 20:26:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:26:49 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6369
Author: @david-livefront
Created: 1/15/2026
Status: ✅ Merged
Merged: 1/15/2026
Merged by: @david-livefront

Base: main ← Head: PM-29694-archive-empty-state

📝 Commits (1)

  • c058a02 PM-29694: Update archive empty state

📊 Changes

5 files changed (+168 additions, -39 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingEmpty.kt (+5 -36)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt (+36 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt (+23 -0)
➕ ui/src/main/res/drawable/ill_open_source.xml (+102 -0)
📝 ui/src/main/res/values/strings.xml (+2 -1)

📄 Description

🎟️ Tracking

PM-29694

📔 Objective

This PR updates the empty state for the vault listing screen for archives. This update copy and adds a new illustration. Additionally, the generic BitwardenEmptyContent was applied to improve code re-usability.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6369 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 1/15/2026 **Status:** ✅ Merged **Merged:** 1/15/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-29694-archive-empty-state` --- ### 📝 Commits (1) - [`c058a02`](https://github.com/bitwarden/android/commit/c058a023b57f3baca36a06d62e7746c8d5889294) PM-29694: Update archive empty state ### 📊 Changes **5 files changed** (+168 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingEmpty.kt` (+5 -36) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt` (+36 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt` (+23 -0) ➕ `ui/src/main/res/drawable/ill_open_source.xml` (+102 -0) 📝 `ui/src/main/res/values/strings.xml` (+2 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-29694](https://bitwarden.atlassian.net/browse/PM-29694) ## 📔 Objective This PR updates the empty state for the vault listing screen for archives. This update copy and adds a new illustration. Additionally, the generic `BitwardenEmptyContent` was applied to improve code re-usability. ## 📸 Screenshots | Before | After | | --- | --- | | <img width="300" src="https://github.com/user-attachments/assets/2bac1ce0-673d-4569-93ee-b17710de04bc" /> | <img width="300" src="https://github.com/user-attachments/assets/7b0f9563-82a7-4e04-9d1c-865554a23d6d" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-29694]: https://bitwarden.atlassian.net/browse/PM-29694?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:26:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54743