github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5094] [MERGED] PM-20365: Add pre-auth settings support #5474

New Issue
Closed
opened 2025-11-27 00:02:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:02:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5094
Author: @david-livefront
Created: 4/24/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @david-livefront

Base: main ← Head: PM-20365-pre-auth-settings

📝 Commits (1)

  • f016788 PM-20365: Add pre-auth settings support

📊 Changes

32 files changed (+657 additions, -289 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+4 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingNavigation.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt (+17 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt (+37 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenMediumTopAppBar.kt (+15 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenTextButton.kt (+4 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTwoButtonDialog.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsNavigation.kt (+97 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt (+18 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt (+36 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutNavigation.kt (+12 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceNavigation.kt (+12 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderNavigation.kt (+14 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/recordedLogs/RecordedLogsNavigation.kt (+20 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherNavigation.kt (+33 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherScreen.kt (+52 -33)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherViewModel.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlocked/VaultUnlockedNavigation.kt (+12 -4)

...and 12 more files

📄 Description

🎟️ Tracking

PM-20365

PM-20380
PM-20381
PM-20382
PM-20383
PM-20384
PM-20582

📔 Objective

This PR adds the pre-auth settings UI flow.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5094 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-20365-pre-auth-settings` --- ### 📝 Commits (1) - [`f016788`](https://github.com/bitwarden/android/commit/f016788f1e5ce0a1ae3ed34ffe6ffb8083916c48) PM-20365: Add pre-auth settings support ### 📊 Changes **32 files changed** (+657 additions, -289 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+4 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingNavigation.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt` (+17 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt` (+37 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenMediumTopAppBar.kt` (+15 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenTextButton.kt` (+4 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTwoButtonDialog.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsNavigation.kt` (+97 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt` (+18 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt` (+36 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutNavigation.kt` (+12 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceNavigation.kt` (+12 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderNavigation.kt` (+14 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/recordedLogs/RecordedLogsNavigation.kt` (+20 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherNavigation.kt` (+33 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherScreen.kt` (+52 -33) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/other/OtherViewModel.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlocked/VaultUnlockedNavigation.kt` (+12 -4) _...and 12 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-20365](https://bitwarden.atlassian.net/browse/PM-20365) [PM-20380](https://bitwarden.atlassian.net/browse/PM-20380) [PM-20381](https://bitwarden.atlassian.net/browse/PM-20381) [PM-20382](https://bitwarden.atlassian.net/browse/PM-20382) [PM-20383](https://bitwarden.atlassian.net/browse/PM-20383) [PM-20384](https://bitwarden.atlassian.net/browse/PM-20384) [PM-20582](https://bitwarden.atlassian.net/browse/PM-20582) ## 📔 Objective This PR adds the pre-auth settings UI flow. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/78560eb5-0e67-43e9-9406-71c4c6976e64" width ="400" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-20365]: https://bitwarden.atlassian.net/browse/PM-20365?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-20380]: https://bitwarden.atlassian.net/browse/PM-20380?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-20381]: https://bitwarden.atlassian.net/browse/PM-20381?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-20382]: https://bitwarden.atlassian.net/browse/PM-20382?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-20383]: https://bitwarden.atlassian.net/browse/PM-20383?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-20384]: https://bitwarden.atlassian.net/browse/PM-20384?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-20582]: https://bitwarden.atlassian.net/browse/PM-20582?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-20583]: https://bitwarden.atlassian.net/browse/PM-20583?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:02:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5474
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?