github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5092] [MERGED] BRE-609/android-pr-target-change #5472

New Issue
Closed
opened 2025-11-27 00:02:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:02:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5092
Author: @aj-bw
Created: 4/24/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @aj-bw

Base: main ← Head: BRE-609/android-pr-target-change

📝 Commits (3)

  • 79095d6 scan workflow edit
  • 1147960 properly designate branches for pull_request
  • 277b850 add types and branches-ignore

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 .github/workflows/scan.yml (+7 -1)

📄 Description

🎟️ Tracking

BRE-609

📔 Objective

edit workflow to ensure pull_request_target event triggers only target main, and that pull_request event triggers target main, rc, hotfix-* so things continue to work as expected

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5092 **Author:** [@aj-bw](https://github.com/aj-bw) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@aj-bw](https://github.com/aj-bw) **Base:** `main` ← **Head:** `BRE-609/android-pr-target-change` --- ### 📝 Commits (3) - [`79095d6`](https://github.com/bitwarden/android/commit/79095d6a3437ef9b50c27f8b7c930e1d454099df) scan workflow edit - [`1147960`](https://github.com/bitwarden/android/commit/114796063505d13c26a1290b5bad924dbfdd0bed) properly designate branches for pull_request - [`277b850`](https://github.com/bitwarden/android/commit/277b850a55523fc72c05a4ddf079257ef5b5f693) add types and branches-ignore ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/scan.yml` (+7 -1) </details> ### 📄 Description ## 🎟️ Tracking [BRE-609](https://bitwarden.atlassian.net/browse/BRE-609) ## 📔 Objective edit workflow to ensure pull_request_target event triggers only target main, and that pull_request event triggers target main, rc, hotfix-* so things continue to work as expected ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [BRE-609]: https://bitwarden.atlassian.net/browse/BRE-609?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:02:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?