github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6274] [MERGED] PM-29827: Move FlightRecorderManager to common data module #54664

New Issue
Closed
opened 2026-05-01 20:21:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:21:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6274
Author: @david-livefront
Created: 12/15/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @david-livefront

Base: main ← Head: PM-29827-common-flight-recorder-manager

📝 Commits (1)

  • 028da4f PM-29827: Move FlightRecorderManager to common data module

📊 Changes

19 files changed (+131 additions, -65 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt (+2 -12)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+3 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/di/PlatformRepositoryModule.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderScreen.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderViewModel.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/util/FlightRecorderDurationExtensions.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderScreenTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderViewModelTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/util/FlightRecorderDurationTests.kt (+1 -1)
📝 data/build.gradle.kts (+2 -0)
➕ data/src/main/kotlin/com/bitwarden/data/datasource/disk/FlightRecorderDiskSource.kt (+19 -0)
📝 data/src/main/kotlin/com/bitwarden/data/manager/flightrecorder/FlightRecorderManager.kt (+26 -2)
📝 data/src/main/kotlin/com/bitwarden/data/manager/flightrecorder/FlightRecorderManagerImpl.kt (+13 -12)
📝 data/src/main/kotlin/com/bitwarden/data/manager/model/FlightRecorderDuration.kt (+1 -1)
📝 data/src/test/kotlin/com/bitwarden/data/manager/flightrecorder/FlightRecorderManagerTest.kt (+23 -24)
➕ data/src/testFixtures/kotlin/com/bitwarden/data/datasource/disk/util/FakeFlightRecorderDiskSource.kt (+32 -0)

📄 Description

🎟️ Tracking

PM-29827

📔 Objective

This PR moves the FlightRecorderManager to the data module. This includes adding a new FlightRecorderDiskSource abstraction.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6274 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 12/15/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-29827-common-flight-recorder-manager` --- ### 📝 Commits (1) - [`028da4f`](https://github.com/bitwarden/android/commit/028da4fe3d2d7951305b756789da9caf8c51db77) PM-29827: Move FlightRecorderManager to common data module ### 📊 Changes **19 files changed** (+131 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt` (+2 -12) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+3 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/di/PlatformRepositoryModule.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderScreen.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderViewModel.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/util/FlightRecorderDurationExtensions.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderScreenTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/FlightRecorderViewModelTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/flightrecorder/util/FlightRecorderDurationTests.kt` (+1 -1) 📝 `data/build.gradle.kts` (+2 -0) ➕ `data/src/main/kotlin/com/bitwarden/data/datasource/disk/FlightRecorderDiskSource.kt` (+19 -0) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/flightrecorder/FlightRecorderManager.kt` (+26 -2) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/flightrecorder/FlightRecorderManagerImpl.kt` (+13 -12) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/model/FlightRecorderDuration.kt` (+1 -1) 📝 `data/src/test/kotlin/com/bitwarden/data/manager/flightrecorder/FlightRecorderManagerTest.kt` (+23 -24) ➕ `data/src/testFixtures/kotlin/com/bitwarden/data/datasource/disk/util/FakeFlightRecorderDiskSource.kt` (+32 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-29827](https://bitwarden.atlassian.net/browse/PM-29827) ## 📔 Objective This PR moves the `FlightRecorderManager` to the data module. This includes adding a new `FlightRecorderDiskSource` abstraction. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-29827]: https://bitwarden.atlassian.net/browse/PM-29827?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:21:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54664
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?