github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6248] [MERGED] [PM-28468] Added service methods to migration to MyItems validation #54648

New Issue
Closed
opened 2026-05-01 20:19:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:19:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6248
Author: @aj-rosado
Created: 12/8/2025
Status: ✅ Merged
Merged: 12/9/2025
Merged by: @aj-rosado

Base: main ← Head: PM-28468/add-methods-to-verify-item-ownership-vault-data

📝 Commits (2)

  • 76d766a Added method to PolicyManager to return the Organization requiring vault data.
  • eda5910 improved code readability on PolicyManagerImpl

📊 Changes

6 files changed (+322 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManager.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt (+7 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+7 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+5 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerTest.kt (+203 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+94 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28468

📔 Objective

Added methods to support validation if user needs to do the vault migration to My Items and tests

  • PolicyManager: Added getPersonalOwnershipPolicyOrganizationId() method that returns the organization ID of the first organization (by revision date) that enabled
    the Personal Ownership policy
  • VaultRepository: Added hasPersonalVaultItems() method to check if the user has any personal vault items (items without an organization ID)

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6248 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 12/8/2025 **Status:** ✅ Merged **Merged:** 12/9/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-28468/add-methods-to-verify-item-ownership-vault-data` --- ### 📝 Commits (2) - [`76d766a`](https://github.com/bitwarden/android/commit/76d766a3b1b311864b7fce21f41d1aa5777f78df) Added method to PolicyManager to return the Organization requiring vault data. - [`eda5910`](https://github.com/bitwarden/android/commit/eda59100598fb2c35e7f82683f594a3b636fd282) improved code readability on PolicyManagerImpl ### 📊 Changes **6 files changed** (+322 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManager.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt` (+7 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+7 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+5 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PolicyManagerTest.kt` (+203 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+94 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-28468 ## 📔 Objective Added methods to support validation if user needs to do the vault migration to My Items and tests * **PolicyManager**: Added `getPersonalOwnershipPolicyOrganizationId()` method that returns the organization ID of the first organization (by revision date) that enabled the Personal Ownership policy * **VaultRepository**: Added `hasPersonalVaultItems()` method to check if the user has any personal vault items (items without an organization ID) ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:19:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54648
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?