[PR #5079] [MERGED] PM-19594: Add flight recorder banner #5461

New Issue

2025-11-27T00:01:21-06:00

GiteaMirror commented

2025-11-27 00:01:21 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5079
Author: @david-livefront
Created: 4/18/2025
Status: ✅ Merged
Merged: 4/21/2025
Merged by: @david-livefront

Base: main ← Head: PM-19594-flight-recorder-banner

📝 Commits (1)

08f735f PM-19594: Add flight recorder banner

📊 Changes

21 files changed (+551 additions, -32 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/FlightRecorderDataSet.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManager.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManagerImpl.kt (+7 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/animation/AnimateNullableContentVisibility.kt (+50 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/fab/BitwardenFloatingActionButton.kt (+7 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/snackbar/BitwardenSnackbar.kt (+31 -16)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/snackbar/BitwardenSnackbarHost.kt (+11 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/snackbar/BitwardenSnackbarHostState.kt (+5 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsNavigation.kt (+21 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultGraphNavigation.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultNavigation.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+22 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+60 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt (+9 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/FlightRecorderDataSetExtensions.kt (+31 -0)
📝 app/src/main/res/values/strings.xml (+3 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManagerTest.kt (+61 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+59 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt (+62 -0)

...and 1 more files

📄 Description

🎟️ Tracking

PM-19594

📔 Objective

This PR adds the flight recorder Snackbar (sorta) to the Vault Screen.

📸 Screenshots

Dismiss	Go To Settings

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5079 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/18/2025 **Status:** ✅ Merged **Merged:** 4/21/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-19594-flight-recorder-banner` --- ### 📝 Commits (1) - [`08f735f`](https://github.com/bitwarden/android/commit/08f735fb84d6b1ca27100d891f917d9cf3986b09) PM-19594: Add flight recorder banner ### 📊 Changes **21 files changed** (+551 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/model/FlightRecorderDataSet.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManager.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManagerImpl.kt` (+7 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/animation/AnimateNullableContentVisibility.kt` (+50 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/fab/BitwardenFloatingActionButton.kt` (+7 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/snackbar/BitwardenSnackbar.kt` (+31 -16) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/snackbar/BitwardenSnackbarHost.kt` (+11 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/snackbar/BitwardenSnackbarHostState.kt` (+5 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsNavigation.kt` (+21 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultGraphNavigation.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultNavigation.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+22 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+60 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt` (+9 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/util/FlightRecorderDataSetExtensions.kt` (+31 -0) 📝 `app/src/main/res/values/strings.xml` (+3 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/flightrecorder/FlightRecorderManagerTest.kt` (+61 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+59 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt` (+62 -0) _...and 1 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-19594](https://bitwarden.atlassian.net/browse/PM-19594) ## 📔 Objective This PR adds the flight recorder Snackbar (sorta) to the Vault Screen. ## 📸 Screenshots | Dismiss | Go To Settings | | --- | --- | | <video src="https://github.com/user-attachments/assets/0f436f00-1f66-45cb-a52d-c75f210f88f6" width="300" /> | <video src="https://github.com/user-attachments/assets/e8d24cd8-089f-4bf1-ba5a-e137588a0fc2" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-19594]: https://bitwarden.atlassian.net/browse/PM-19594?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-27 00:01:21 -06:00

GiteaMirror closed this issue