github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6002] [MERGED] PM-26575: Add AuthTab support for WebAuthN, Duo, and SSO #54442

New Issue
Closed
opened 2026-05-01 19:56:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 19:56:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6002
Author: @david-livefront
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/10/2025
Merged by: @david-livefront

Base: main ← Head: PM-26575-auth-tabs

📝 Commits (1)

  • 4ac247b PM-26575: Add AuthTab support for WebAuthN, Duo, and SSO

📊 Changes

16 files changed (+381 additions, -37 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt (+20 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt (+36 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/DuoUtils.kt (+36 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/SsoUtils.kt (+32 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WebAuthUtils.kt (+29 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt (+4 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt (+5 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+10 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/model/AuthTabLaunchers.kt (+15 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt (+61 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/DuoUtilsTest.kt (+77 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreenTest.kt (+11 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreenTest.kt (+17 -6)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/base/BitwardenComposeTest.kt (+3 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManager.kt (+9 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManagerImpl.kt (+16 -0)

📄 Description

🎟️ Tracking

PM-26575

📔 Objective

This PR adds support for AuthTabs when logging in with Duo, WebAuthn, and SSO login flows.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ���️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6002 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/10/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-26575-auth-tabs` --- ### 📝 Commits (1) - [`4ac247b`](https://github.com/bitwarden/android/commit/4ac247b173ced8e2f5e37fc44f78a9a6a52dfca6) PM-26575: Add AuthTab support for WebAuthN, Duo, and SSO ### 📊 Changes **16 files changed** (+381 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainActivity.kt` (+20 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt` (+36 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/DuoUtils.kt` (+36 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/SsoUtils.kt` (+32 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WebAuthUtils.kt` (+29 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt` (+4 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt` (+5 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+10 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/model/AuthTabLaunchers.kt` (+15 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/MainViewModelTest.kt` (+61 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/DuoUtilsTest.kt` (+77 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreenTest.kt` (+11 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreenTest.kt` (+17 -6) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/base/BitwardenComposeTest.kt` (+3 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManager.kt` (+9 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManagerImpl.kt` (+16 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-26575](https://bitwarden.atlassian.net/browse/PM-26575) ## 📔 Objective This PR adds support for `AuthTabs` when logging in with Duo, WebAuthn, and SSO login flows. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ���️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-26575]: https://bitwarden.atlassian.net/browse/PM-26575?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 19:56:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54442
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?