github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5986] [MERGED] [PM-24258] Building a specific Fido2AttestationResponse to work with Binance #54427

New Issue
Closed
opened 2026-05-01 19:54:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 19:54:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5986
Author: @aj-rosado
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/10/2025
Merged by: @aj-rosado

Base: main ← Head: PM-24258/binance-passkeys-issue

📝 Commits (3)

  • 34f443a Building a specific Fido2AttestationResponse to work with Binance
  • a663e3a Undo changes on Fido2AttestationResponse
  • 650de19 improved code readibility

📊 Changes

3 files changed (+63 additions, -16 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt (+6 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensions.kt (+21 -11)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensionsTest.kt (+36 -4)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24258

📔 Objective

When creating a passkey on Binance it is being labeled as "Broken".
Sending a sanitized Fido2AttestationResponse with the response object without the transports on the Binance flow fixes that.

fixes https://github.com/bitwarden/android/issues/5608

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5986 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/10/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-24258/binance-passkeys-issue` --- ### 📝 Commits (3) - [`34f443a`](https://github.com/bitwarden/android/commit/34f443ae20dfc105fcba9fd84dccf06bd4e25a98) Building a specific Fido2AttestationResponse to work with Binance - [`a663e3a`](https://github.com/bitwarden/android/commit/a663e3a53d19b6d34dcc71c05aa3cc1870beaa96) Undo changes on Fido2AttestationResponse - [`650de19`](https://github.com/bitwarden/android/commit/650de1910b20b604f0800d3da8ee5b5fe328127b) improved code readibility ### 📊 Changes **3 files changed** (+63 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt` (+6 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensions.kt` (+21 -11) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/util/PublicKeyCredentialAuthenticatorAttestationResponseExtensionsTest.kt` (+36 -4) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-24258 ## 📔 Objective When creating a passkey on Binance it is being labeled as "Broken". Sending a sanitized `Fido2AttestationResponse` with the `response` object without the `transports` on the Binance flow fixes that. fixes https://github.com/bitwarden/android/issues/5608 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 19:54:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#54427
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?