[PR #5057] [MERGED] Use explicit timezone in tests #5440

New Issue

2025-11-26T23:59:53-06:00

GiteaMirror commented

2025-11-26 23:59:53 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5057
Author: @david-livefront
Created: 4/14/2025
Status: ✅ Merged
Merged: 4/14/2025
Merged by: @david-livefront

Base: main ← Head: fix-test-time-zone

📝 Commits (1)

1fb2916 Use explicit timezone in tests

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModelTest.kt (+2 -2)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This is addresses a minor bug in the AboutViewModelTests where the test was using the system default timezone. This can cause discrepancies between output of a time based on the timezone of the dev machine and the CI machine. Currently it is not an issue because this class has no tests like that but this will avoid a future headache if someone were to add more featues/tests.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5057 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/14/2025 **Status:** ✅ Merged **Merged:** 4/14/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `fix-test-time-zone` --- ### 📝 Commits (1) - [`1fb2916`](https://github.com/bitwarden/android/commit/1fb2916a336afd6c4855a2bfee6076176d635749) Use explicit timezone in tests ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModelTest.kt` (+2 -2) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This is addresses a minor bug in the `AboutViewModelTests` where the test was using the system default timezone. This can cause discrepancies between output of a time based on the timezone of the dev machine and the CI machine. Currently it is not an issue because this class has no tests like that but this will avoid a future headache if someone were to add more featues/tests. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:59:53 -06:00

GiteaMirror closed this issue