github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-17 08:58:36 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #5034] [MERGED] [PM-18936] Show key connector domain #5421

New Issue
Closed
opened 2025-11-26 23:59:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:59:36 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5034
Author: @aj-rosado
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/17/2025
Merged by: @aj-rosado

Base: main ← Head: PM-18936/show-key-connector-domain

📝 Commits (10+)

  • df3c5b1 Added key connector domain and leave organization button to RemovePasswordScreen
  • c0c7fee Added validation prompt before setting up KeyConnector for a new user
  • debb74a fixed leave organization call
  • 9ca9379 Added tests
  • b16005d Merge branch 'main' into PM-18936/show-key-connector-domain
  • 987f432 Added : to RemovePassword labels
  • babec11 Merge branch 'main' into PM-18936/show-key-connector-domain
  • b4dcca4 Added more tests to leave organization
  • 4edc6f2 Merge branch 'main' into PM-18936/show-key-connector-domain
  • fa630c7 removed unnecessary breakline on strings

📊 Changes

36 files changed (+1098 additions, -15 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+47 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/LeaveOrganizationResult.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/LoginResult.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/LogoutReason.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/Organization.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensions.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt (+24 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt (+57 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModel.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModel.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordScreen.kt (+83 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordViewModel.kt (+110 -8)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt (+3 -0)
📝 app/src/main/res/values/strings.xml (+5 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+215 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensionsTest.kt (+6 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensionsTest.kt (+6 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensionsTest.kt (+16 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreenTest.kt (+73 -0)

...and 16 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18936

📔 Objective

When removing password from an existing user, show the key connector domain and added an option to leave the organization.

When is a new user, prompt the user to confirm the domain.

📸 Screenshots

Remove password screen Confirm key connector dialog

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5034 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/17/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-18936/show-key-connector-domain` --- ### 📝 Commits (10+) - [`df3c5b1`](https://github.com/bitwarden/android/commit/df3c5b1347df7067216393983ce04475ba5792fe) Added key connector domain and leave organization button to RemovePasswordScreen - [`c0c7fee`](https://github.com/bitwarden/android/commit/c0c7feefebf4f1adbd25ee159274896f2a799812) Added validation prompt before setting up KeyConnector for a new user - [`debb74a`](https://github.com/bitwarden/android/commit/debb74a0a6a3004303a1ee8e6d2f2d1f78708d22) fixed leave organization call - [`9ca9379`](https://github.com/bitwarden/android/commit/9ca93792607bd5a993eb90880e8b2c346414a9a6) Added tests - [`b16005d`](https://github.com/bitwarden/android/commit/b16005d3cd07614533fc016d62de0ee1b5b92dc9) Merge branch 'main' into PM-18936/show-key-connector-domain - [`987f432`](https://github.com/bitwarden/android/commit/987f43278c29fb33b3903a4bd70d82b1baea925d) Added : to RemovePassword labels - [`babec11`](https://github.com/bitwarden/android/commit/babec11588618baaab24f745a53e10429a0a8458) Merge branch 'main' into PM-18936/show-key-connector-domain - [`b4dcca4`](https://github.com/bitwarden/android/commit/b4dcca4552ffeae73f35b68eacf3942ed6780a21) Added more tests to leave organization - [`4edc6f2`](https://github.com/bitwarden/android/commit/4edc6f221182e7549dcc250a30845f2edffa0f7e) Merge branch 'main' into PM-18936/show-key-connector-domain - [`fa630c7`](https://github.com/bitwarden/android/commit/fa630c7055a060fe432d363e2d5af0d56d20b6fa) removed unnecessary breakline on strings ### 📊 Changes **36 files changed** (+1098 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+47 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/LeaveOrganizationResult.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/LoginResult.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/LogoutReason.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/Organization.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensions.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt` (+24 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt` (+57 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModel.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModel.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordScreen.kt` (+83 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/removepassword/RemovePasswordViewModel.kt` (+110 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt` (+3 -0) 📝 `app/src/main/res/values/strings.xml` (+5 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+215 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensionsTest.kt` (+6 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensionsTest.kt` (+6 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensionsTest.kt` (+16 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreenTest.kt` (+73 -0) _...and 16 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-18936 ## 📔 Objective When removing password from an existing user, show the key connector domain and added an option to leave the organization. When is a new user, prompt the user to confirm the domain. ## 📸 Screenshots <img width="314" alt="Remove password screen" src="https://github.com/user-attachments/assets/d0fc1c5a-a4c1-4cbc-80e0-a57c16b87b1b"> <img width="314" alt="Confirm key connector dialog" src="https://github.com/user-attachments/assets/5ebd4080-f98f-4333-898f-f59a04864f40"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:59:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5421