github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 20:24:33 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5026] [MERGED] [PM-20127] Only prompt passkey user verification once #5414

New Issue
Closed
opened 2025-11-26 23:59:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:59:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5026
Author: @SaintPatrck
Created: 4/10/2025
Status: ✅ Merged
Merged: 4/16/2025
Merged by: @SaintPatrck

Base: main ← Head: passkeys/cache-user-verification-result

📝 Commits (1)

  • 76cf844 [PM-20127] Only prompt passkey user verification once

📊 Changes

15 files changed (+530 additions, -104 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+7 -10)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+89 -86)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CreateCredentialRequest.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequest.kt (+7 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt (+16 -0)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+7 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequestUtil.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialRequestUtil.kt (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtilsTest.kt (+81 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensionsTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+3 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/Fido2CredentialRequestExtensionsTest.kt (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+309 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt (+1 -0)

📄 Description

🎟️ Tracking

PM-20127

📔 Objective

Prevent user verification from prompting twice when single-tap passkey processing is enabled.

  • Added isUserPreVerified property to Fido2CreateCredentialRequest and Fido2CredentialAssertionRequest to indicate if the user has been verified by the OS biometric prompt.
  • Updated Fido2IntentUtils to extract the OS biometric prompt result from request data and include it in isUserPreVerified.
  • Updated MainViewModel to set the user's verification status based on isUserPreVerified when a new FIDO 2 request is received.
  • Updated FIDO2 logic in VaultItemListingViewModel and VaultAddEditViewModel to support new Fido2GetCredentialsRequest.
  • Removed some redundant methods from Fido2CredentialManagerImpl.
  • Added tests for Fido2GetCredentialsRequest handling in VaultItemListingViewModel.
  • Updated tests to use new isUserPreVerified in Fido2CreateCredentialRequest.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5026 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 4/16/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `passkeys/cache-user-verification-result` --- ### 📝 Commits (1) - [`76cf844`](https://github.com/bitwarden/android/commit/76cf844f931dec2cd0c70ee6ce92725d5616567d) [PM-20127] Only prompt passkey user verification once ### 📊 Changes **15 files changed** (+530 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+7 -10) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+89 -86) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CreateCredentialRequest.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequest.kt` (+7 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt` (+16 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+7 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequestUtil.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialRequestUtil.kt` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtilsTest.kt` (+81 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensionsTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+3 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/Fido2CredentialRequestExtensionsTest.kt` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+309 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-20127 ## 📔 Objective Prevent user verification from prompting twice when single-tap passkey processing is enabled. - Added `isUserPreVerified` property to `Fido2CreateCredentialRequest` and `Fido2CredentialAssertionRequest` to indicate if the user has been verified by the OS biometric prompt. - Updated `Fido2IntentUtils` to extract the OS biometric prompt result from request data and include it in `isUserPreVerified`. - Updated `MainViewModel` to set the user's verification status based on `isUserPreVerified` when a new FIDO 2 request is received. - Updated FIDO2 logic in `VaultItemListingViewModel` and `VaultAddEditViewModel` to support new `Fido2GetCredentialsRequest`. - Removed some redundant methods from `Fido2CredentialManagerImpl`. - Added tests for `Fido2GetCredentialsRequest` handling in `VaultItemListingViewModel`. - Updated tests to use new `isUserPreVerified` in `Fido2CreateCredentialRequest`. ## 📸 Screenshots Coming soon! ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:59:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5414
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?