github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 04:03:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4998] [MERGED] Remove unused FeatureFlagRepository and FeatureFlagDiskSource #5387

New Issue
Closed
opened 2025-11-26 23:59:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:59:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4998
Author: @SaintPatrck
Created: 4/4/2025
Status: ✅ Merged
Merged: 4/7/2025
Merged by: @SaintPatrck

Base: main ← Head: authenticator/remove-unused-featureflag-repo

📝 Commits (1)

  • 717339b Remove unused FeatureFlagRepository and FeatureFlagDiskSource

📊 Changes

10 files changed (+0 additions, -344 deletions)

View changed files

➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/FeatureFlagDiskSource.kt (+0 -20)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/FeatureFlagDiskSourceImpl.kt (+0 -41)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/di/PlatformDiskModule.kt (+0 -13)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/FeatureFlagRepository.kt (+0 -20)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/FeatureFlagRepositoryImpl.kt (+0 -47)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/di/PlatformRepositoryModule.kt (+0 -14)
➖ authenticator/src/test/java/com/bitwarden/authenticator/data/platform/datasource/disk/FeatureFlagDiskSourceTest.kt (+0 -71)
➖ authenticator/src/test/java/com/bitwarden/authenticator/data/platform/datasource/disk/util/FakeFeatureFlagDiskSource.kt (+0 -27)
➖ authenticator/src/test/java/com/bitwarden/authenticator/data/platform/repository/FeatureFlagRepositoryTest.kt (+0 -53)
➖ authenticator/src/test/java/com/bitwarden/authenticator/data/platform/repository/util/FakeFeatureFlagRepository.kt (+0 -38)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This commit removes the Feature Flag repository, its dependencies, and related test files. Specifically:

  • Removed FeatureFlagRepository and FeatureFlagRepositoryImpl.
  • Removed FeatureFlagDiskSource and FeatureFlagDiskSourceImpl.
  • Removed the associated test files: FakeFeatureFlagDiskSource, FeatureFlagDiskSourceTest, FakeFeatureFlagRepository, and FeatureFlagRepositoryTest.
  • Removed FeatureFlagDiskSource from PlatformDiskModule and PlatformRepositoryModule as dependency injection.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4998 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/4/2025 **Status:** ✅ Merged **Merged:** 4/7/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `authenticator/remove-unused-featureflag-repo` --- ### 📝 Commits (1) - [`717339b`](https://github.com/bitwarden/android/commit/717339bf5d56594ca107f12448546fd1716bcfa7) Remove unused FeatureFlagRepository and FeatureFlagDiskSource ### 📊 Changes **10 files changed** (+0 additions, -344 deletions) <details> <summary>View changed files</summary> ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/FeatureFlagDiskSource.kt` (+0 -20) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/FeatureFlagDiskSourceImpl.kt` (+0 -41) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/di/PlatformDiskModule.kt` (+0 -13) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/FeatureFlagRepository.kt` (+0 -20) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/FeatureFlagRepositoryImpl.kt` (+0 -47) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/di/PlatformRepositoryModule.kt` (+0 -14) ➖ `authenticator/src/test/java/com/bitwarden/authenticator/data/platform/datasource/disk/FeatureFlagDiskSourceTest.kt` (+0 -71) ➖ `authenticator/src/test/java/com/bitwarden/authenticator/data/platform/datasource/disk/util/FakeFeatureFlagDiskSource.kt` (+0 -27) ➖ `authenticator/src/test/java/com/bitwarden/authenticator/data/platform/repository/FeatureFlagRepositoryTest.kt` (+0 -53) ➖ `authenticator/src/test/java/com/bitwarden/authenticator/data/platform/repository/util/FakeFeatureFlagRepository.kt` (+0 -38) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This commit removes the Feature Flag repository, its dependencies, and related test files. Specifically: - Removed `FeatureFlagRepository` and `FeatureFlagRepositoryImpl`. - Removed `FeatureFlagDiskSource` and `FeatureFlagDiskSourceImpl`. - Removed the associated test files: `FakeFeatureFlagDiskSource`, `FeatureFlagDiskSourceTest`, `FakeFeatureFlagRepository`, and `FeatureFlagRepositoryTest`. - Removed `FeatureFlagDiskSource` from `PlatformDiskModule` and `PlatformRepositoryModule` as dependency injection. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:59:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5387
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?