github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #4956] [CLOSED] Checkmarx vuln test #5347

New Issue
Closed
opened 2025-11-26 23:58:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:58:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4956
Author: @mandreko-bitwarden
Created: 4/1/2025
Status: ❌ Closed

Base: main ← Head: checkmarx-test

📝 Commits (3)

  • 791dcf1 Added file with checkmarx hardcoded pass finding
  • 5c00805 Copied finding file
  • 5dc6376 Merge branch 'main' into checkmarx-test

📊 Changes

2 files changed (+2284 additions, -0 deletions)

View changed files

➕ app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/BackupVaultViewModelTest.kt (+2108 -0)
➕ send.command.ts (+176 -0)

📄 Description

🎟️ Tracking

DO NOT MERGE

📔 Objective

DO NOT MERGE

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4956 **Author:** [@mandreko-bitwarden](https://github.com/mandreko-bitwarden) **Created:** 4/1/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `checkmarx-test` --- ### 📝 Commits (3) - [`791dcf1`](https://github.com/bitwarden/android/commit/791dcf189e2a39024829ddca1f7fa4fc84d3db4c) Added file with checkmarx hardcoded pass finding - [`5c00805`](https://github.com/bitwarden/android/commit/5c00805e4014ea9932851cb464e862474fc4d077) Copied finding file - [`5dc6376`](https://github.com/bitwarden/android/commit/5dc6376778abbf0dc1fe8ffbfc10ba3c8b4df0e9) Merge branch 'main' into checkmarx-test ### 📊 Changes **2 files changed** (+2284 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/vault/BackupVaultViewModelTest.kt` (+2108 -0) ➕ `send.command.ts` (+176 -0) </details> ### 📄 Description ## 🎟️ Tracking DO NOT MERGE ## 📔 Objective DO NOT MERGE ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:58:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?