[PR #4945] [MERGED] PM-19404: Improve email validation and validation error parsing #5338

New Issue

2025-11-26T23:58:17-06:00

GiteaMirror commented

2025-11-26 23:58:17 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4945
Author: @david-livefront
Created: 3/31/2025
Status: ✅ Merged
Merged: 3/31/2025
Merged by: @david-livefront

Base: main ← Head: PM-19404-email-validation

📝 Commits (1)

3bc1cf6 PM-19404: Improve email validation and validation error parsing

📊 Changes

4 files changed (+39 additions, -27 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/SendVerificationEmailResponseJson.kt (+11 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/StringExtensions.kt (+10 -3)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+1 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/base/util/StringExtensionsTest.kt (+17 -17)

📄 Description

🎟️ Tracking

PM-19404
PM-19771

📔 Objective

This PR updates 2 things in order to improve email validation.

The logic for validating an email address has been updated to actually check that the string is an email address.
The error message displayed to the user is checking the validation errors from the API.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4945 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-19404-email-validation` --- ### 📝 Commits (1) - [`3bc1cf6`](https://github.com/bitwarden/android/commit/3bc1cf63415307818cf84c2a3d867ba3cb1468ad) PM-19404: Improve email validation and validation error parsing ### 📊 Changes **4 files changed** (+39 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/SendVerificationEmailResponseJson.kt` (+11 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/StringExtensions.kt` (+10 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+1 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/base/util/StringExtensionsTest.kt` (+17 -17) </details> ### 📄 Description ## 🎟️ Tracking [PM-19404](https://bitwarden.atlassian.net/browse/PM-19404) [PM-19771](https://bitwarden.atlassian.net/browse/PM-19771) ## 📔 Objective This PR updates 2 things in order to improve email validation. * The logic for validating an email address has been updated to actually check that the string is an email address. * The error message displayed to the user is checking the validation errors from the API. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-19404]: https://bitwarden.atlassian.net/browse/PM-19404?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-19771]: https://bitwarden.atlassian.net/browse/PM-19771?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:58:17 -06:00

GiteaMirror closed this issue