github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4673] [MERGED] PM-17769 Icons added to the settings menu rows #53332

New Issue
Closed
opened 2026-05-01 18:04:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 18:04:09 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4673
Author: @dseverns-livefront
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/3/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-17769-icon-on-settings-screen

📝 Commits (4)

  • 88c56fc PM-17769 add icons for the main settings menu items
  • e5fe15a fix padding amount on divider
  • d0b030f divider padding take in to account LTR
  • 5b7ed86 mover ltr check into divider

📊 Changes

6 files changed (+103 additions, -13 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt (+11 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt (+33 -11)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt (+8 -0)
➕ app/src/main/res/drawable/ic_filter.xml (+22 -0)
➕ app/src/main/res/drawable/ic_info_circle.xml (+16 -0)
➕ app/src/main/res/drawable/ic_paintbrush.xml (+13 -0)

📄 Description

🎟️ Tracking

PM-17769

📔 Objective

  • Add icons to each settings row to match v3 design.

📸 Screenshots

Updated:
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4673 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/3/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-17769-icon-on-settings-screen` --- ### 📝 Commits (4) - [`88c56fc`](https://github.com/bitwarden/android/commit/88c56fc2c210f89ca5f59ef095aaf6f42646b8fd) PM-17769 add icons for the main settings menu items - [`e5fe15a`](https://github.com/bitwarden/android/commit/e5fe15ad0a125db54ae78aeb3731686fafdec1eb) fix padding amount on divider - [`d0b030f`](https://github.com/bitwarden/android/commit/d0b030ffda9cab58d610ad0a4ec7c11990c90abf) divider padding take in to account LTR - [`5b7ed86`](https://github.com/bitwarden/android/commit/5b7ed86511bef40736da59f41d5d2902cd2f11b3) mover ltr check into divider ### 📊 Changes **6 files changed** (+103 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt` (+11 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt` (+33 -11) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt` (+8 -0) ➕ `app/src/main/res/drawable/ic_filter.xml` (+22 -0) ➕ `app/src/main/res/drawable/ic_info_circle.xml` (+16 -0) ➕ `app/src/main/res/drawable/ic_paintbrush.xml` (+13 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-17769](https://bitwarden.atlassian.net/browse/PM-17769) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Add icons to each settings row to match v3 design. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots Updated: ![image](https://github.com/user-attachments/assets/8053a4eb-22cd-4d47-b2b7-ece38051c97e) <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17769]: https://bitwarden.atlassian.net/browse/PM-17769?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 18:04:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#53332