github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 19:54:19 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4937] [MERGED] [PM-19652] Consolidate check configurations #5331

New Issue
Closed
opened 2025-11-26 23:58:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:58:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4937
Author: @SaintPatrck
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/31/2025
Merged by: @vvolkgang

Base: main ← Head: shared-modules/core-workflows

📝 Commits (9)

  • 963f9db [PM-19652] Refactor testing workflows and configurations
  • 5fcdeeb Upload coverage report during test step
  • 4376ac3 Revert changes to codecov.yml
  • 36c5f66 Revert temp changes to MainViewModelTest.kt
  • c5e5684 Update fastlane check task
  • 1b16f33 Update detekt sources to include all src/* files
  • 8b7343f Add upload reports step back to test job
  • fb63c31 User release as matching fallback for beta build types
  • c0f83d7 Let gradle do its thing

📊 Changes

11 files changed (+155 additions, -303 deletions)

View changed files

📝 .github/workflows/build-authenticator.yml (+1 -1)
➖ .github/workflows/test-authenticator.yml (+0 -82)
📝 .github/workflows/test.yml (+7 -19)
📝 app/build.gradle.kts (+1 -96)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/util/BuildConfigTest.kt (+6 -1)
📝 authenticator/build.gradle.kts (+0 -86)
📝 authenticatorbridge/build.gradle.kts (+2 -2)
📝 authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/EncryptionUtilTest.kt (+9 -3)
📝 authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/TestAuthenticatorBridgeCallbackProvider.kt (+5 -4)
📝 build.gradle.kts (+115 -2)
📝 fastlane/Fastfile (+9 -7)

📄 Description

🎟️ Tracking

PM-19652

📔 Objective

Centralize configurations for testing and validation plugins into the root project. Code coverage reporting for all modules is consolidated into a single report.

  • Removed the test-authenticator.yml workflow, as all the test logic is now in test.yml.
  • Updated the test.yml workflow to generate and collect a merged Kover coverage report.
  • Consolidated detekt, kover, and sonar configuration to the root build.gradle.kts file.
  • Adjusted Kover to run against standardDebug and fdroidDebug variants.
  • Modified Fastfile to use koverXmlReportMergedCoverage instead of koverXmlReportDebug.
  • Removed detekt and kover configurations from modules authenticator, and app to use the root configuration.

Changes applied to resolve build errors:

  • Corrected OS version support check to OsVersionNotSupported in AccountSyncState.
  • Run detekt and apply fixes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4937 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `shared-modules/core-workflows` --- ### 📝 Commits (9) - [`963f9db`](https://github.com/bitwarden/android/commit/963f9dba089b7901f67feafe5e0d59363b61d0c3) [PM-19652] Refactor testing workflows and configurations - [`5fcdeeb`](https://github.com/bitwarden/android/commit/5fcdeeb2a50e75208a93dcc93b4f52875ef47779) Upload coverage report during test step - [`4376ac3`](https://github.com/bitwarden/android/commit/4376ac36cff9ee5c45a63c00231c0a6a2053f220) Revert changes to codecov.yml - [`36c5f66`](https://github.com/bitwarden/android/commit/36c5f669d323b724e1c1ca764d04fd993504af13) Revert temp changes to MainViewModelTest.kt - [`c5e5684`](https://github.com/bitwarden/android/commit/c5e5684ed53ce52aa87a6ec7239578af3391a2a7) Update fastlane `check` task - [`1b16f33`](https://github.com/bitwarden/android/commit/1b16f33609392570c79d3280ff5bca89f7b518cd) Update detekt sources to include all `src/*` files - [`8b7343f`](https://github.com/bitwarden/android/commit/8b7343f48dd5a1ea94a840b6011add4efa7e6b29) Add upload reports step back to test job - [`fb63c31`](https://github.com/bitwarden/android/commit/fb63c3191bfa182a6233d1daa87ea34f9999a61a) User `release` as matching fallback for beta build types - [`c0f83d7`](https://github.com/bitwarden/android/commit/c0f83d7f2bc43938a1ea79db2282f346b72c3a02) Let gradle do its thing ### 📊 Changes **11 files changed** (+155 additions, -303 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-authenticator.yml` (+1 -1) ➖ `.github/workflows/test-authenticator.yml` (+0 -82) 📝 `.github/workflows/test.yml` (+7 -19) 📝 `app/build.gradle.kts` (+1 -96) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/util/BuildConfigTest.kt` (+6 -1) 📝 `authenticator/build.gradle.kts` (+0 -86) 📝 `authenticatorbridge/build.gradle.kts` (+2 -2) 📝 `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/EncryptionUtilTest.kt` (+9 -3) 📝 `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/TestAuthenticatorBridgeCallbackProvider.kt` (+5 -4) 📝 `build.gradle.kts` (+115 -2) 📝 `fastlane/Fastfile` (+9 -7) </details> ### 📄 Description ## 🎟️ Tracking PM-19652 ## 📔 Objective Centralize configurations for testing and validation plugins into the root project. Code coverage reporting for all modules is consolidated into a single report. - Removed the `test-authenticator.yml` workflow, as all the test logic is now in `test.yml`. - Updated the `test.yml` workflow to generate and collect a merged Kover coverage report. - Consolidated `detekt`, `kover`, and `sonar` configuration to the root `build.gradle.kts` file. - Adjusted Kover to run against `standardDebug` and `fdroidDebug` variants. - Modified `Fastfile` to use `koverXmlReportMergedCoverage` instead of `koverXmlReportDebug`. - Removed `detekt` and `kover` configurations from modules `authenticator`, and `app` to use the root configuration. Changes applied to resolve build errors: - Corrected OS version support check to `OsVersionNotSupported` in `AccountSyncState`. - Run detekt and apply fixes ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:58:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?