github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4925] [MERGED] [PM-8331] Using default send url when on US cloud #5319

New Issue
Closed
opened 2025-11-26 23:57:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4925
Author: @aj-rosado
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @aj-rosado

Base: main ← Head: PM-8331/update-send-share-url

📝 Commits (6)

  • d3e099f Using DEFAULT_WEB_SEND_URL if we are on DEFAULT_WEB_VAULT_URL
  • 05effb6 Added test to verify DEFAULT_WEB_SEND_URL is returned when web vault is DEFAULT_WEB_VAULT_URL
  • 1b6a90e Merge branch 'main' into PM-8331/update-send-share-url
  • e0f840e Formatting code
  • 277cce3 added comment explaining if clause to use default send url
  • e43c6d1 Fix tests

📊 Changes

5 files changed (+26 additions, -7 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/util/EnvironmentUrlDataJsonExtensions.kt (+9 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/util/EnvironmentUrlsDataJsonExtensionsTest.kt (+11 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModelTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataUtil.kt (+4 -4)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8331

📔 Objective

When on US Cloud, when copying the send url we should use the https://send.bitwarden.com/# url instead of the vault url.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4925 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-8331/update-send-share-url` --- ### 📝 Commits (6) - [`d3e099f`](https://github.com/bitwarden/android/commit/d3e099f94f5770d6ddc45c765686c33d0ecdc385) Using DEFAULT_WEB_SEND_URL if we are on DEFAULT_WEB_VAULT_URL - [`05effb6`](https://github.com/bitwarden/android/commit/05effb68e2b8590e51f25486f1e7ee9fa5ec3e14) Added test to verify DEFAULT_WEB_SEND_URL is returned when web vault is DEFAULT_WEB_VAULT_URL - [`1b6a90e`](https://github.com/bitwarden/android/commit/1b6a90ec19cb8b5d0af30b07bc54a2156c61b2d9) Merge branch 'main' into PM-8331/update-send-share-url - [`e0f840e`](https://github.com/bitwarden/android/commit/e0f840ecc70945d3dbb5e042ba9722f99e0638f6) Formatting code - [`277cce3`](https://github.com/bitwarden/android/commit/277cce31a0720f33fcd81779e9d76b15a64d2233) added comment explaining if clause to use default send url - [`e43c6d1`](https://github.com/bitwarden/android/commit/e43c6d1a8b16352878d447e5c103fcc9a9d43331) Fix tests ### 📊 Changes **5 files changed** (+26 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/util/EnvironmentUrlDataJsonExtensions.kt` (+9 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/util/EnvironmentUrlsDataJsonExtensionsTest.kt` (+11 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModelTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataUtil.kt` (+4 -4) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-8331 ## 📔 Objective When on US Cloud, when copying the send url we should use the https://send.bitwarden.com/# url instead of the vault url. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5319
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?