github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4915] [MERGED] Replace landscape and portrait logic with sceen width logic #5311

New Issue
Closed
opened 2025-11-26 23:57:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4915
Author: @david-livefront
Created: 3/25/2025
Status: ✅ Merged
Merged: 3/26/2025
Merged by: @david-livefront

Base: main ← Head: PM-19519-screen-size-support

📝 Commits (1)

  • c76a5f8 Replace landscape and portrait logic with sceen width logic

📊 Changes

14 files changed (+186 additions, -119 deletions)

View changed files

📝 app/build.gradle.kts (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt (+18 -16)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreen.kt (+7 -10)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+18 -16)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt (+23 -19)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt (+45 -19)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/model/WindowSize.kt (+9 -0)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/util/ConfigurationExtensions.kt (+0 -15)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/util/WindowAdaptiveInfoExtensions.kt (+33 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+5 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+6 -8)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt (+17 -14)
📝 gradle/libs.versions.toml (+1 -0)

📄 Description

🎟️ Tracking

PM-19519

📔 Objective

This PR removes logic based on portrait and landscape and replaces it with logic using the window size buckets. Currently only compact and medium are being supported but this new mechanism is setup to support more types such as expanded an other larger sizes.

More information can be found here:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4915 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/25/2025 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-19519-screen-size-support` --- ### 📝 Commits (1) - [`c76a5f8`](https://github.com/bitwarden/android/commit/c76a5f8aad9ccb94bc1ecd3b48eb2c98a6a430a4) Replace landscape and portrait logic with sceen width logic ### 📊 Changes **14 files changed** (+186 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt` (+18 -16) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreen.kt` (+7 -10) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+18 -16) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt` (+23 -19) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt` (+45 -19) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/model/WindowSize.kt` (+9 -0) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/util/ConfigurationExtensions.kt` (+0 -15) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/util/WindowAdaptiveInfoExtensions.kt` (+33 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+5 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+6 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt` (+17 -14) 📝 `gradle/libs.versions.toml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-19519](https://bitwarden.atlassian.net/browse/PM-19519) ## 📔 Objective This PR removes logic based on portrait and landscape and replaces it with logic using the window size buckets. Currently only `compact` and `medium` are being supported but this new mechanism is setup to support more types such as `expanded` an other larger sizes. More information can be found here: * https://developer.android.com/develop/ui/compose/layouts/adaptive/use-window-size-classes#manage_layouts_with_window_size_classes * https://m3.material.io/blog/material-you-large-screens ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-19519]: https://bitwarden.atlassian.net/browse/PM-19519?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?