github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4898] [CLOSED] [PM-19108] Enhance Privileged Apps List View #5296

New Issue
Closed
opened 2025-11-26 23:57:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4898
Author: @SaintPatrck
Created: 3/19/2025
Status: ❌ Closed

Base: innovation-sprint/privileged-apps/settings-mgmt ← Head: innovation-sprint/privileged-apps/list-item-updates

📝 Commits (1)

  • 54b23eb [PM-19108] Enhance Privileged Apps List View

📊 Changes

10 files changed (+394 additions, -175 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+3 -0)
📝 app/src/main/assets/fido2_privileged_community.json (+0 -12)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/BitwardenPackageManager.kt (+17 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/BitwardenPackageManagerImpl.kt (+34 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+8 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/PrivilegedAppsListScreen.kt (+191 -104)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/PrivilegedAppsListViewModel.kt (+101 -56)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/model/PrivilegedAppListItem.kt (+31 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+1 -1)
📝 app/src/main/res/values/strings.xml (+8 -1)

📄 Description

🎟️ Tracking

PM-19108

📔 Objective

Refactor the Privileged Apps List view to provide a more comprehensive and user-friendly display of trusted applications.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4898 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/19/2025 **Status:** ❌ Closed **Base:** `innovation-sprint/privileged-apps/settings-mgmt` ← **Head:** `innovation-sprint/privileged-apps/list-item-updates` --- ### 📝 Commits (1) - [`54b23eb`](https://github.com/bitwarden/android/commit/54b23eb469af12daf5d206ec075b592d7800eb5a) [PM-19108] Enhance Privileged Apps List View ### 📊 Changes **10 files changed** (+394 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+3 -0) 📝 `app/src/main/assets/fido2_privileged_community.json` (+0 -12) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/BitwardenPackageManager.kt` (+17 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/BitwardenPackageManagerImpl.kt` (+34 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+8 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/PrivilegedAppsListScreen.kt` (+191 -104) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/PrivilegedAppsListViewModel.kt` (+101 -56) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/model/PrivilegedAppListItem.kt` (+31 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+1 -1) 📝 `app/src/main/res/values/strings.xml` (+8 -1) </details> ### 📄 Description ## 🎟️ Tracking PM-19108 ## 📔 Objective Refactor the Privileged Apps List view to provide a more comprehensive and user-friendly display of trusted applications. ## 📸 Screenshots Coming soon! ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5296
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?