github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4896] [CLOSED] [PM-19355] Update BrowserUtil.kt: add support for /e/OS Browser package #5294

New Issue
Closed
opened 2025-11-26 23:57:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4896
Author: @nathanael-h
Created: 3/19/2025
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (3)

  • 24eea14 Update BrowserUtil.kt: add support for /e/OS Browser package
  • dde29eb Update autofill_service_configuration.xml: add foundation.e.browser
  • 172bfad Update BrowserUtil.kt: maintain alphabetic ordering

📊 Changes

2 files changed (+4 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/util/BrowserUtil.kt (+1 -0)
📝 app/src/main/res/xml/autofill_service_configuration.xml (+3 -0)

📄 Description

The /e/OS Browser is a fork of Cromite, using the package id foundation.e.browser, see https://gitlab.e.foundation/e/os/browser/-/blob/master/build/browser.gn_args?ref_type=heads#L56

🎟️ Tracking

I did not saw related issue in this repo, but in /e/ issues tracker there are :

📔 Objective

I hope this simple patch can fix the auto-fill with this Browser and Bitwarden on Android.

📸 Screenshots

Not relevant

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4896 **Author:** [@nathanael-h](https://github.com/nathanael-h) **Created:** 3/19/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`24eea14`](https://github.com/bitwarden/android/commit/24eea1451c04f5dc12801a38e1e32c572e9ef374) Update BrowserUtil.kt: add support for /e/OS Browser package - [`dde29eb`](https://github.com/bitwarden/android/commit/dde29eb429d1b133204a4e942ff9580649e11a52) Update autofill_service_configuration.xml: add foundation.e.browser - [`172bfad`](https://github.com/bitwarden/android/commit/172bfad99b7465c8053016bd12e47cc9dab916f5) Update BrowserUtil.kt: maintain alphabetic ordering ### 📊 Changes **2 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/util/BrowserUtil.kt` (+1 -0) 📝 `app/src/main/res/xml/autofill_service_configuration.xml` (+3 -0) </details> ### 📄 Description The /e/OS Browser is a fork of Cromite, using the package id `foundation.e.browser`, see https://gitlab.e.foundation/e/os/browser/-/blob/master/build/browser.gn_args?ref_type=heads#L56 ## 🎟️ Tracking I did not saw related issue in this repo, but in /e/ issues tracker there are : - https://gitlab.e.foundation/e/backlog/-/issues/3739 - https://gitlab.e.foundation/e/backlog/-/issues/3319 ## 📔 Objective I hope this simple patch can fix the auto-fill with this Browser and Bitwarden on Android. ## 📸 Screenshots Not relevant ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5294
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?