github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4891] [MERGED] BWA-119 - Unable to Access Manual Code Entry After Denying Camera Permissions on #5290

New Issue
Closed
opened 2025-11-26 23:57:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4891
Author: @phil-livefront
Created: 3/18/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @phil-livefront

Base: main ← Head: phil/BWA-119-Unable-to-Access-Manual-Code-Entry-After-Denying-Camera-Permissions-on

📝 Commits (2)

  • b1b78f1 BWA-119 - remove dialog and update flow to show manual entry screen when permissions are not granted
  • 7f121b1 Merge branch 'main' into phil/BWA-119-Unable-to-Access-Manual-Code-Entry-After-Denying-Camera-Permissions-on

📊 Changes

2 files changed (+37 additions, -23 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt (+5 -23)
📝 authenticator/src/test/java/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreenTest.kt (+32 -0)

📄 Description

🎟️ Tracking

BWA-119

📔 Objective

  • The issue was that the manual entry screen was not being displayed when attempting to add a new code. Instead, a dialog prompted the user to open Settings, but upon dismissing the dialog, they remained on the same tab.
  • After discussing with Luke, we determined that the expected behavior should match iOS, which does not display a dialog. Instead, if permissions are not granted, the manual entry screen should be shown directly. This also follows the flow of the Password Manager android app.
  • Fixed typo in onScanQrCodeClick

📸 Screenshots

Before

https://github.com/user-attachments/assets/6094c1c8-626f-4140-b270-3ee7e23479ee

After

https://github.com/user-attachments/assets/142ae99e-ad14-4c4b-b9ef-23758bc03faa

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4891 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 3/18/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/BWA-119-Unable-to-Access-Manual-Code-Entry-After-Denying-Camera-Permissions-on` --- ### 📝 Commits (2) - [`b1b78f1`](https://github.com/bitwarden/android/commit/b1b78f12d756f17abd65fea40b785e78f0163250) BWA-119 - remove dialog and update flow to show manual entry screen when permissions are not granted - [`7f121b1`](https://github.com/bitwarden/android/commit/7f121b157d650e99eb04b36aadad54e2e8a36cd1) Merge branch 'main' into phil/BWA-119-Unable-to-Access-Manual-Code-Entry-After-Denying-Camera-Permissions-on ### 📊 Changes **2 files changed** (+37 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt` (+5 -23) 📝 `authenticator/src/test/java/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreenTest.kt` (+32 -0) </details> ### 📄 Description ## 🎟️ Tracking [BWA-119](https://bitwarden.atlassian.net/browse/BWA-119) ## 📔 Objective - The issue was that the manual entry screen was not being displayed when attempting to add a new code. Instead, a dialog prompted the user to open Settings, but upon dismissing the dialog, they remained on the same tab. - After discussing with Luke, we determined that the expected behavior should match iOS, which does not display a dialog. Instead, if permissions are not granted, the manual entry screen should be shown directly. This also follows the flow of the Password Manager android app. - Fixed typo in `onScanQrCodeClick` ## 📸 Screenshots ### Before https://github.com/user-attachments/assets/6094c1c8-626f-4140-b270-3ee7e23479ee ### After https://github.com/user-attachments/assets/142ae99e-ad14-4c4b-b9ef-23758bc03faa ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [BWA-119]: https://bitwarden.atlassian.net/browse/BWA-119?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5290
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?