github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-13 23:31:21 -05:00
Code Issues 1.1k Packages Projects Releases 124 Wiki Activity

[PR #4887] [CLOSED] [DynamicColors] Navigation bar items support dynamic colors #5288

New Issue
Closed
opened 2025-11-26 23:57:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:57:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4887
Author: @SaintPatrck
Created: 3/17/2025
Status: ❌ Closed

Base: innovation-sprint/dynamic-colors/bitwarden-switch-colors ← Head: innovation-sprint/dynamic-colors/bottom-nav-icons

📝 Commits (2)

  • 2de6527 [DynamicColors] Navigation bar items support dynamic colors
  • cedcbff Update nav bar icon vectors and dynamic color scheme

📊 Changes

18 files changed (+31 additions, -189 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/navigation/BitwardenNavigationBarItem.kt (+6 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/color/ColorScheme.kt (+1 -1)
➖ app/src/main/res/drawable-night/ic_generator.xml (+0 -29)
➖ app/src/main/res/drawable-night/ic_generator_filled.xml (+0 -32)
➖ app/src/main/res/drawable-night/ic_send.xml (+0 -14)
➖ app/src/main/res/drawable-night/ic_send_filled.xml (+0 -17)
➖ app/src/main/res/drawable-night/ic_settings.xml (+0 -18)
➖ app/src/main/res/drawable-night/ic_settings_filled.xml (+0 -21)
➖ app/src/main/res/drawable-night/ic_vault.xml (+0 -14)
➖ app/src/main/res/drawable-night/ic_vault_filled.xml (+0 -17)
📝 app/src/main/res/drawable/ic_generator.xml (+5 -5)
📝 app/src/main/res/drawable/ic_generator_filled.xml (+6 -6)
📝 app/src/main/res/drawable/ic_send.xml (+1 -1)
📝 app/src/main/res/drawable/ic_send_filled.xml (+2 -2)
📝 app/src/main/res/drawable/ic_settings.xml (+2 -2)
📝 app/src/main/res/drawable/ic_settings_filled.xml (+3 -3)
📝 app/src/main/res/drawable/ic_vault.xml (+2 -2)
📝 app/src/main/res/drawable/ic_vault_filled.xml (+3 -3)

📄 Description

🎟️ Tracking

📔 Objective

Update bottom nav bar icons to support dynamic colors.

Updated the colors of nav icons and the tint color of the navigation bar items to improve consistency and theming with dynamic colors.

Changed the navigation bar item icon colors to use icon.primary and icon.secondary from the Bitwarden theme.

Updated the selected icon to use icon.secondary and the unselected icon to use icon.primary.

Since tint is being applied to monochrome icons the -night versions are no longer necessary so they have been removed.

Modified the fill color of several filled icons to #70000000 and non-filled icons to #A0000000, including ic_vault, ic_settings, ic_send, ic_generator, ic_settings_filled, ic_send_filled, ic_generator_filled, and ic_vault_filled.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4887 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/17/2025 **Status:** ❌ Closed **Base:** `innovation-sprint/dynamic-colors/bitwarden-switch-colors` ← **Head:** `innovation-sprint/dynamic-colors/bottom-nav-icons` --- ### 📝 Commits (2) - [`2de6527`](https://github.com/bitwarden/android/commit/2de65270b13c4c8cd36ee78ccf70506c3e738b89) [DynamicColors] Navigation bar items support dynamic colors - [`cedcbff`](https://github.com/bitwarden/android/commit/cedcbff42b266129fe61e07e4b9acb9fd3eb54c1) Update nav bar icon vectors and dynamic color scheme ### 📊 Changes **18 files changed** (+31 additions, -189 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/navigation/BitwardenNavigationBarItem.kt` (+6 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/color/ColorScheme.kt` (+1 -1) ➖ `app/src/main/res/drawable-night/ic_generator.xml` (+0 -29) ➖ `app/src/main/res/drawable-night/ic_generator_filled.xml` (+0 -32) ➖ `app/src/main/res/drawable-night/ic_send.xml` (+0 -14) ➖ `app/src/main/res/drawable-night/ic_send_filled.xml` (+0 -17) ➖ `app/src/main/res/drawable-night/ic_settings.xml` (+0 -18) ➖ `app/src/main/res/drawable-night/ic_settings_filled.xml` (+0 -21) ➖ `app/src/main/res/drawable-night/ic_vault.xml` (+0 -14) ➖ `app/src/main/res/drawable-night/ic_vault_filled.xml` (+0 -17) 📝 `app/src/main/res/drawable/ic_generator.xml` (+5 -5) 📝 `app/src/main/res/drawable/ic_generator_filled.xml` (+6 -6) 📝 `app/src/main/res/drawable/ic_send.xml` (+1 -1) 📝 `app/src/main/res/drawable/ic_send_filled.xml` (+2 -2) 📝 `app/src/main/res/drawable/ic_settings.xml` (+2 -2) 📝 `app/src/main/res/drawable/ic_settings_filled.xml` (+3 -3) 📝 `app/src/main/res/drawable/ic_vault.xml` (+2 -2) 📝 `app/src/main/res/drawable/ic_vault_filled.xml` (+3 -3) </details> ### 📄 Description ## 🎟️ Tracking ## 📔 Objective Update bottom nav bar icons to support dynamic colors. Updated the colors of nav icons and the tint color of the navigation bar items to improve consistency and theming with dynamic colors. Changed the navigation bar item icon colors to use `icon.primary` and `icon.secondary` from the Bitwarden theme. Updated the selected icon to use `icon.secondary` and the unselected icon to use `icon.primary`. Since tint is being applied to monochrome icons the `-night` versions are no longer necessary so they have been removed. Modified the fill color of several filled icons to `#70000000` and non-filled icons to `#A0000000`, including `ic_vault`, `ic_settings`, `ic_send`, `ic_generator`, `ic_settings_filled`, `ic_send_filled`, `ic_generator_filled`, and `ic_vault_filled`. ## 📸 Screenshots Coming soon! ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:57:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?