github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #4012] [MERGED] [PM-13074] Explicitly sync FIDO2 credentials #52826

New Issue
Closed
opened 2026-05-01 17:12:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 17:12:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4012
Author: @SaintPatrck
Created: 10/1/2024
Status: ✅ Merged
Merged: 10/2/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-13074/suspendable-sync

📝 Commits (1)

  • a9ad567 [PM-13074] Explicitly sync FIDO2 credentials

📊 Changes

5 files changed (+207 additions, -82 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt (+13 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+90 -69)
➕ app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/SyncVaultDataResult.kt (+18 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+79 -11)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13074

📔 Objective

This commit introduces an explicit sync for FIDO2 credentials, ensuring they are up-to-date when accessed. It modifies the Fido2CredentialStoreImpl to call syncFido2Credentials instead of the generic sync method.

Additionally, it adds a new syncFido2Credentials method to the VaultRepository interface and implements it in VaultRepositoryImpl, allowing for targeted FIDO2 credential synchronization. A new sealed class, SyncFido2CredentialsResult, is introduced to represent the outcome of this sync operation.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4012 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 10/1/2024 **Status:** ✅ Merged **Merged:** 10/2/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-13074/suspendable-sync` --- ### 📝 Commits (1) - [`a9ad567`](https://github.com/bitwarden/android/commit/a9ad56773e9c845293df50d7d908443c78ab0c6b) [PM-13074] Explicitly sync FIDO2 credentials ### 📊 Changes **5 files changed** (+207 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt` (+13 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+90 -69) ➕ `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/SyncVaultDataResult.kt` (+18 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+79 -11) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13074 ## 📔 Objective This commit introduces an explicit sync for FIDO2 credentials, ensuring they are up-to-date when accessed. It modifies the `Fido2CredentialStoreImpl` to call `syncFido2Credentials` instead of the generic `sync` method. Additionally, it adds a new `syncFido2Credentials` method to the `VaultRepository` interface and implements it in `VaultRepositoryImpl`, allowing for targeted FIDO2 credential synchronization. A new sealed class, `SyncFido2CredentialsResult`, is introduced to represent the outcome of this sync operation. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 17:12:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?