github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 06:04:20 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4872] [MERGED] PM-19243 send result errors propagated to UI #5275

New Issue
Closed
opened 2025-11-26 23:56:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4872
Author: @dseverns-livefront
Created: 3/14/2025
Status: ✅ Merged
Merged: 3/14/2025
Merged by: @david-livefront

Base: main ← Head: PM-19243-prop-send-result-errors

📝 Commits (1)

  • d3cec9e PM-19243 send result errors propagated to UI

📊 Changes

18 files changed (+146 additions, -64 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+39 -16)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/CreateSendResult.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/DeleteSendResult.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/RemovePasswordSendResult.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/UpdateSendResult.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+4 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt (+4 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModel.kt (+6 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+9 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+49 -26)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt (+6 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModelTest.kt (+4 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModelTest.kt (+9 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+8 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19243

📔 Objective

  • Propagate send related result errors to the UI.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4872 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-19243-prop-send-result-errors` --- ### 📝 Commits (1) - [`d3cec9e`](https://github.com/bitwarden/android/commit/d3cec9eba6fda3f833fcf16e886527986f9def11) PM-19243 send result errors propagated to UI ### 📊 Changes **18 files changed** (+146 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+39 -16) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/CreateSendResult.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/DeleteSendResult.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/RemovePasswordSendResult.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/model/UpdateSendResult.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+4 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt` (+4 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModel.kt` (+6 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+9 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+49 -26) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt` (+6 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModelTest.kt` (+4 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModelTest.kt` (+9 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+8 -2) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-19243 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Propagate send related result errors to the UI. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?