github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4862] [CLOSED] [PM-19108] Add privileged app management screen #5265

New Issue
Closed
opened 2025-11-26 23:56:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4862
Author: @SaintPatrck
Created: 3/13/2025
Status: ❌ Closed

Base: main ← Head: innovation-sprint/privileged-apps/settings-mgmt

📝 Commits (6)

  • 9beb3ec Implement privileged app management for FIDO2
  • 3dde47d [PM-19108] Add privileged app management screen
  • 5fdad28 Update UI based on feedback from Design
  • b4fd2da Add delete vector icon and update delete button icon in privileged apps list
  • bdce805 Remove unused strings
  • 3c1ef13 Fix compilation failure

📊 Changes

57 files changed (+2970 additions, -1008 deletions)

View changed files

📝 app/src/main/assets/fido2_privileged_community.json (+0 -2)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/Fido2PrivilegedAppDiskSource.kt (+36 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/Fido2PrivilegedAppDiskSourceImpl.kt (+52 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/dao/Fido2PrivilegedAppInfoDao.kt (+40 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/database/Fido2PrivilegedAppDatabase.kt (+22 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/di/Fido2DiskModule.kt (+54 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/entity/Fido2PrivilegedAppInfoEntity.kt (+19 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt (+24 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+153 -71)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerImpl.kt (+64 -34)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionResult.kt (+36 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt (+4 -7)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2RegisterCredentialResult.kt (+55 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2ValidateOriginResult.kt (+42 -31)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PrivilegedAppAllowListJson.kt (+66 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PrivilegedAppData.kt (+10 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/repository/PrivilegedAppRepository.kt (+62 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/repository/PrivilegedAppRepositoryImpl.kt (+187 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensions.kt (+3 -3)

...and 37 more files

📄 Description

🎟️ Tracking

PM-19108

📔 Objective

Allow users to manage trusted privileged applications and view
privileged applications that are trusted by external sources.

📸 Screenshots

https://github.com/user-attachments/assets/e7dc588d-5b6b-4602-8737-790e1e612492

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4862 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/13/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `innovation-sprint/privileged-apps/settings-mgmt` --- ### 📝 Commits (6) - [`9beb3ec`](https://github.com/bitwarden/android/commit/9beb3ecd6a9e6016421fb23375398e90dfa3fbea) Implement privileged app management for FIDO2 - [`3dde47d`](https://github.com/bitwarden/android/commit/3dde47d0c64e534bba83834b1b9888909e0be22a) [PM-19108] Add privileged app management screen - [`5fdad28`](https://github.com/bitwarden/android/commit/5fdad28cdb1da60bf362ff00d914ea628d58fea2) Update UI based on feedback from Design - [`b4fd2da`](https://github.com/bitwarden/android/commit/b4fd2dadb869b551a450e87abbe9ba72474dc336) Add delete vector icon and update delete button icon in privileged apps list - [`bdce805`](https://github.com/bitwarden/android/commit/bdce8050b6bb153e70e63da5e7cb05586f2185ca) Remove unused strings - [`3c1ef13`](https://github.com/bitwarden/android/commit/3c1ef13c79bda5db505b32375cd89bc7bc26c3fb) Fix compilation failure ### 📊 Changes **57 files changed** (+2970 additions, -1008 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/assets/fido2_privileged_community.json` (+0 -2) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/Fido2PrivilegedAppDiskSource.kt` (+36 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/Fido2PrivilegedAppDiskSourceImpl.kt` (+52 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/dao/Fido2PrivilegedAppInfoDao.kt` (+40 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/database/Fido2PrivilegedAppDatabase.kt` (+22 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/di/Fido2DiskModule.kt` (+54 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/datasource/disk/entity/Fido2PrivilegedAppInfoEntity.kt` (+19 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt` (+24 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManager.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+153 -71) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2OriginManagerImpl.kt` (+64 -34) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionResult.kt` (+36 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt` (+4 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2RegisterCredentialResult.kt` (+55 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2ValidateOriginResult.kt` (+42 -31) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PrivilegedAppAllowListJson.kt` (+66 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/PrivilegedAppData.kt` (+10 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/repository/PrivilegedAppRepository.kt` (+62 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/repository/PrivilegedAppRepositoryImpl.kt` (+187 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/util/CallingAppInfoExtensions.kt` (+3 -3) _...and 37 more files_ </details> ### 📄 Description ## 🎟️ Tracking PM-19108 ## 📔 Objective Allow users to manage trusted privileged applications and view privileged applications that are trusted by external sources. ## 📸 Screenshots https://github.com/user-attachments/assets/e7dc588d-5b6b-4602-8737-790e1e612492 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5265
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?