github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 22:00:42 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4858] [MERGED] [PM-19049] Add workflow to regularly fetch updates to fido2_privileged_google.json #5261

New Issue
Closed
opened 2025-11-26 23:56:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4858
Author: @vvolkgang
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @vvolkgang

Base: main ← Head: sync-allow-list

📝 Commits (4)

  • 347de4b Add sync workflow and json file validation python scripts
  • 06c7e68 Fix linting
  • bfc1853 Update .github/scripts/validate-json/.python-version
  • d8f0752 Update .gitignore

📊 Changes

9 files changed (+426 additions, -0 deletions)

View changed files

➕ .github/scripts/validate-json/.python-version (+1 -0)
➕ .github/scripts/validate-json/README.md (+39 -0)
➕ .github/scripts/validate-json/fixtures/sample-invalid.json (+20 -0)
➕ .github/scripts/validate-json/fixtures/sample-valid1.json (+48 -0)
➕ .github/scripts/validate-json/fixtures/sample-valid2.json (+20 -0)
➕ .github/scripts/validate-json/test_validate_json.py (+48 -0)
➕ .github/scripts/validate-json/validate_json.py (+145 -0)
➕ .github/workflows/cron-sync-google-priviledged-browsers.yml (+98 -0)
📝 .gitignore (+7 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19049

📔 Objective

Adds a GitHub Workflow to regularly check for updates to fido2_privileged_google.json and open a Pull Request. When changes are found, we confirm that we're able to deserialise the updated json file and check for duplicates between fido2_privileged_google.json and fido2_privileged_community.json. When duplicates are found, a warning is added to the PR description.

Note

Opening a Pull Request with GITHUB_TOKEN means checks won't automatically run. We'll later introduce a bot to improve this, as a workaround closing and re-opening the PR will kickstart checks.

📸 Screenshots

PR description when duplicates are found:

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4858 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `sync-allow-list` --- ### 📝 Commits (4) - [`347de4b`](https://github.com/bitwarden/android/commit/347de4b4c6fe21021c76a08e3757e27b4a7ab102) Add sync workflow and json file validation python scripts - [`06c7e68`](https://github.com/bitwarden/android/commit/06c7e683c90dafe64ebaf87f4bae18520515c3fc) Fix linting - [`bfc1853`](https://github.com/bitwarden/android/commit/bfc185366a309e80af1b7bf738aae9357bd54a0d) Update .github/scripts/validate-json/.python-version - [`d8f0752`](https://github.com/bitwarden/android/commit/d8f0752ee7cf0b78b331168ea122b98930d8f388) Update .gitignore ### 📊 Changes **9 files changed** (+426 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/scripts/validate-json/.python-version` (+1 -0) ➕ `.github/scripts/validate-json/README.md` (+39 -0) ➕ `.github/scripts/validate-json/fixtures/sample-invalid.json` (+20 -0) ➕ `.github/scripts/validate-json/fixtures/sample-valid1.json` (+48 -0) ➕ `.github/scripts/validate-json/fixtures/sample-valid2.json` (+20 -0) ➕ `.github/scripts/validate-json/test_validate_json.py` (+48 -0) ➕ `.github/scripts/validate-json/validate_json.py` (+145 -0) ➕ `.github/workflows/cron-sync-google-priviledged-browsers.yml` (+98 -0) 📝 `.gitignore` (+7 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-19049 ## 📔 Objective Adds a GitHub Workflow to regularly check for updates to fido2_privileged_google.json and open a Pull Request. When changes are found, we confirm that we're able to deserialise the updated json file and check for duplicates between `fido2_privileged_google.json` and `fido2_privileged_community.json`. When duplicates are found, a warning is added to the PR description. > [!NOTE] > Opening a Pull Request with `GITHUB_TOKEN` means checks won't automatically run. We'll later introduce a bot to improve this, as a workaround closing and re-opening the PR will kickstart checks. ## 📸 Screenshots PR description when duplicates are found: <img width="903" alt="image" src="https://github.com/user-attachments/assets/a52a6435-ceae-49b2-a520-c3cfbf4b76e9" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5261
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?