github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3622] [MERGED] [PM-6702] 6# Complete registration screen #52508

New Issue
Closed
opened 2026-05-01 16:37:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:37:22 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3622
Author: @andrebispo5
Created: 7/24/2024
Status: ✅ Merged
Merged: 8/16/2024
Merged by: @andrebispo5

Base: main ← Head: pm-6702/evf-complete-registration

📝 Commits (10+)

  • 764c0a3 [PM-6702] Send verification email service
  • b1d0053 [PM-6702] Register finish service call
  • 5356dff [PM-6702] Add service tests
  • 81138a3 [PM-6702] Save and load region for a given email in shared preferences
  • e21487f [PM-6702] Tests for save and load region for a given email
  • 552570c [PM-6702] Update manifest to handle App Links
  • e24c6f6 [PM-6702] Convert App Link intent into a special circumstance to open Complete Registration
  • e8915f4 [PM-6702] Add copy for email verification feature
  • 6365b78 [PM-6702] Extract environment selector to its own file
  • 959ded8 [PM-6702] Make Landing use the extracted environment selector

📊 Changes

19 files changed (+1660 additions, -11 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+13 -1)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt (+70 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+236 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt (+493 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicator.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt (+10 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModel.kt (+1 -1)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt (+249 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationTestUtil.kt (+18 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt (+540 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreenTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModelTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt (+21 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreenTest.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModelTest.kt (+1 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-6701
https://bitwarden.atlassian.net/browse/PM-6702

📔 Objective

Add the final step of account creation.
This screen is mostly built using old create account code, the diferences are the receiving of an email registration token, the load of the region used on start registration and the removal of captcha.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3622 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 7/24/2024 **Status:** ✅ Merged **Merged:** 8/16/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-6702/evf-complete-registration` --- ### 📝 Commits (10+) - [`764c0a3`](https://github.com/bitwarden/android/commit/764c0a3901cdf4f6f542cf6cbcfef835c16f6275) [PM-6702] Send verification email service - [`b1d0053`](https://github.com/bitwarden/android/commit/b1d0053393606e4da1513dbcf7b1f1a006ed4755) [PM-6702] Register finish service call - [`5356dff`](https://github.com/bitwarden/android/commit/5356dffe25c4b536b688e9444dfce72df96880da) [PM-6702] Add service tests - [`81138a3`](https://github.com/bitwarden/android/commit/81138a3ca8afcf76e72a30176285497fafc80210) [PM-6702] Save and load region for a given email in shared preferences - [`e21487f`](https://github.com/bitwarden/android/commit/e21487f5e003745209e8f1131f02c0e529af6f2b) [PM-6702] Tests for save and load region for a given email - [`552570c`](https://github.com/bitwarden/android/commit/552570cc2907abf1932bd7a7e9773aa0e02953d6) [PM-6702] Update manifest to handle App Links - [`e24c6f6`](https://github.com/bitwarden/android/commit/e24c6f6008941748747ddcbad573d7c2054ef957) [PM-6702] Convert App Link intent into a special circumstance to open Complete Registration - [`e8915f4`](https://github.com/bitwarden/android/commit/e8915f48ab5a41d9677d9168518d3b2ff0727805) [PM-6702] Add copy for email verification feature - [`6365b78`](https://github.com/bitwarden/android/commit/6365b78653524b50eef65fe4103ae1714e4a3566) [PM-6702] Extract environment selector to its own file - [`959ded8`](https://github.com/bitwarden/android/commit/959ded851cc909c88d8209fb2b213a98c0cd15d6) [PM-6702] Make Landing use the extracted environment selector ### 📊 Changes **19 files changed** (+1660 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+13 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt` (+70 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+236 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt` (+493 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicator.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt` (+10 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModel.kt` (+1 -1) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt` (+249 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationTestUtil.kt` (+18 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt` (+540 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreenTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModelTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt` (+21 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreenTest.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModelTest.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-6701 https://bitwarden.atlassian.net/browse/PM-6702 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Add the final step of account creation. This screen is mostly built using old create account code, the diferences are the receiving of an email registration token, the load of the region used on start registration and the removal of captcha. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> <img width="360" alt="image" src="https://github.com/user-attachments/assets/fb4612c4-deb9-46b3-9d01-7f84ae998b20"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:37:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52508