github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3533] [MERGED] [Build Issue] use full source set to match fastfile test task #52464

New Issue
Closed
opened 2026-05-01 16:32:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:32:13 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3533
Author: @dseverns-livefront
Created: 7/15/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @dseverns-livefront

Base: main ← Head: detekt-consistency-on-open-and-merge

📝 Commits (1)

  • aa4f231 use full source set to match fastfile test task

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/build.gradle.kts (+1 -1)

📄 Description

I believe this is why there are cases of the builds passing on open PR jobs for Detekt but then failing on the merge job. I think cause this is triggered by the sonar check only in the dev builds it passes the check if all the files in the main source set pass, but ignores the tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3533 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 7/15/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `detekt-consistency-on-open-and-merge` --- ### 📝 Commits (1) - [`aa4f231`](https://github.com/bitwarden/android/commit/aa4f2313c74ace925f69fc8518e71873de495f46) use full source set to match fastfile test task ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+1 -1) </details> ### 📄 Description I believe this is why there are cases of the builds passing on open PR jobs for `Detekt` but then failing on the merge job. I think cause this is triggered by the sonar `check` only in the dev builds it passes the check if all the files in the `main` source set pass, but ignores the tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:32:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52464