github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4835] [MERGED] [PM-17995] Adjust custom fields section #5245

New Issue
Closed
opened 2025-11-26 23:56:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4835
Author: @andrebispo5
Created: 3/7/2025
Status: ✅ Merged
Merged: 3/13/2025
Merged by: @andrebispo5

Base: main ← Head: pm-17995/adjust-custom-fields

📝 Commits (4)

  • e310fe9 [PM-17995] Change button label
  • 43dfe08 [PM-17995] Adjust margin from section title to add field button
  • 9bfafb2 [PM-17995] Fix tests
  • f8fafa2 Merge branch 'main' into pm-17995/adjust-custom-fields

📊 Changes

4 files changed (+14 additions, -12 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditAdditionalOptions.kt (+2 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomFieldsButton.kt (+1 -1)
📝 app/src/main/res/values/strings.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+10 -10)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17995

📔 Objective

Fix Custom Fields section label and Add field button margin.
Change the button label from "New custom field" to "Add field".

📸 Screenshots

Screenshot 2025-03-07 at 10 16 55 Screenshot 2025-03-07 at 10 16 43

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4835 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 3/7/2025 **Status:** ✅ Merged **Merged:** 3/13/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-17995/adjust-custom-fields` --- ### 📝 Commits (4) - [`e310fe9`](https://github.com/bitwarden/android/commit/e310fe9e42932b273a3ee5876b8b8e85d4017032) [PM-17995] Change button label - [`43dfe08`](https://github.com/bitwarden/android/commit/43dfe0803f2a075fde421bab67d8f68194ecccfc) [PM-17995] Adjust margin from section title to add field button - [`9bfafb2`](https://github.com/bitwarden/android/commit/9bfafb25b4f3f905b02a52ef512a8cbd3d3a4357) [PM-17995] Fix tests - [`f8fafa2`](https://github.com/bitwarden/android/commit/f8fafa2b5908901db106206b37b9e7184cbf9e58) Merge branch 'main' into pm-17995/adjust-custom-fields ### 📊 Changes **4 files changed** (+14 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditAdditionalOptions.kt` (+2 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomFieldsButton.kt` (+1 -1) 📝 `app/src/main/res/values/strings.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+10 -10) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-17995 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Fix **Custom Fields** section label and **Add field** button margin. Change the button label from "New custom field" to "Add field". ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> <img width="292" alt="Screenshot 2025-03-07 at 10 16 55" src="https://github.com/user-attachments/assets/98e9641e-a3d1-483f-80ce-18ecbcf7d0c3" /> <img width="295" alt="Screenshot 2025-03-07 at 10 16 43" src="https://github.com/user-attachments/assets/c7932edb-76e7-4bca-8073-0a5a1f4af2a7" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5245
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?