github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #4814] [MERGED] [PM-18873] Refactor ItemHeader.kt to improve location display #5234

New Issue
Closed
opened 2025-11-26 23:56:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4814
Author: @SaintPatrck
Created: 3/4/2025
Status: ✅ Merged
Merged: 3/7/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-18873/vaultitem-header-show-folder

📝 Commits (4)

  • fe74bad [PM-18873] Refactor ItemHeader.kt to improve location display
  • 6f9ee8f Merge remote-tracking branch 'origin/main' into PM-18873/vaultitem-header-show-folder
  • e8370ed Use middle card style when necessary
  • 375b051 Merge remote-tracking branch 'origin/main' into PM-18873/vaultitem-header-show-folder

📊 Changes

3 files changed (+160 additions, -38 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/component/ItemHeader.kt (+100 -36)
📝 app/src/main/res/values/strings.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+59 -2)

📄 Description

🎟️ Tracking

PM-18873

📔 Objective

Only collapse item locations when it is assigned to multiple Collections.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4814 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/4/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-18873/vaultitem-header-show-folder` --- ### 📝 Commits (4) - [`fe74bad`](https://github.com/bitwarden/android/commit/fe74badd6d17f3cf9d8916bf627af2ee80d8df92) [PM-18873] Refactor `ItemHeader.kt` to improve location display - [`6f9ee8f`](https://github.com/bitwarden/android/commit/6f9ee8f95c1421bfc922a4a0fd1804fbe81da123) Merge remote-tracking branch 'origin/main' into PM-18873/vaultitem-header-show-folder - [`e8370ed`](https://github.com/bitwarden/android/commit/e8370ede53ef9891b43e098e3d48c301a3c983a0) Use middle card style when necessary - [`375b051`](https://github.com/bitwarden/android/commit/375b051ad80cd918eed27153c668b28cbf75f089) Merge remote-tracking branch 'origin/main' into PM-18873/vaultitem-header-show-folder ### 📊 Changes **3 files changed** (+160 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/component/ItemHeader.kt` (+100 -36) 📝 `app/src/main/res/values/strings.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+59 -2) </details> ### 📄 Description ## 🎟️ Tracking PM-18873 ## 📔 Objective Only collapse item locations when it is assigned to multiple Collections. ## 📸 Screenshots <img width="365" alt="image" src="https://github.com/user-attachments/assets/27c1a037-7ade-46d3-9579-1b570824f594" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5234
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?