github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3215] [MERGED] [PM-7877] Added loading dialog when unlocking with PIN #52312

New Issue
Closed
opened 2026-05-01 16:15:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:15:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3215
Author: @fedemkr
Created: 5/3/2024
Status: ✅ Merged
Merged: 5/3/2024
Merged by: @fedemkr

Base: main ← Head: mobiletf/pm-7877/pin-invalid

📝 Commits (2)

  • 8327346 PM-7877 Added loading dialog when unlocking with PIN
  • 4feea0e PM-7877 Added exception logging on unlock with PIN

📊 Changes

1 file changed (+16 additions, -5 deletions)

View changed files

📝 src/Core/Pages/Accounts/LockPageViewModel.cs (+16 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add loading dialog when unlocking with PIN

Code changes

  • LockPageViewModel: Added loading dialog when unlocking with PIN and logging exceptions.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3215 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 5/3/2024 **Status:** ✅ Merged **Merged:** 5/3/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `main` ← **Head:** `mobiletf/pm-7877/pin-invalid` --- ### 📝 Commits (2) - [`8327346`](https://github.com/bitwarden/android/commit/832734613759b7c3cc06d34b8b211327a0633326) PM-7877 Added loading dialog when unlocking with PIN - [`4feea0e`](https://github.com/bitwarden/android/commit/4feea0eedc7ca5ce1ccd72591a69cab18e5d31c5) PM-7877 Added exception logging on unlock with PIN ### 📊 Changes **1 file changed** (+16 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Accounts/LockPageViewModel.cs` (+16 -5) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add loading dialog when unlocking with PIN ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **LockPageViewModel:** Added loading dialog when unlocking with PIN and logging exceptions. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:15:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?