github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-18 14:19:36 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3154] [MERGED] [PM-7366] Select cipher on search on Fido2 creation #52272

New Issue
Closed
opened 2026-05-01 16:12:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:12:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3154
Author: @fedemkr
Created: 4/12/2024
Status: ✅ Merged
Merged: 4/15/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7366/select-cipher-on-search-on-passkey-creation

📝 Commits (2)

  • 742a802 PM-7366 Implemented cipher selection on search on passkey creation
  • e652b9b PM-7366 Fix typo

📊 Changes

5 files changed (+53 additions, -21 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs (+21 -2)
📝 src/App/Platforms/Android/MainApplication.cs (+2 -1)
📝 src/Core/Abstractions/IFido2MakeCredentialConfirmationUserInterface.cs (+17 -1)
📝 src/Core/Pages/Vault/AutofillCiphersPageViewModel.cs (+1 -17)
📝 src/Core/Pages/Vault/CiphersPageViewModel.cs (+12 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implemented cipher selection on search on Fido2 creation

Code changes

  • Fido2MakeCredentialUserInterface: Moved logic of cipher selection check to create a Fido2 credential here in order to be reused between cipher list and search.
  • CiphersPageViewModel: Added call to the aforementioned UserInterface to select a cipher for Fido2 creation

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3154 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/12/2024 **Status:** ✅ Merged **Merged:** 4/15/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7366/select-cipher-on-search-on-passkey-creation` --- ### 📝 Commits (2) - [`742a802`](https://github.com/bitwarden/android/commit/742a80210753469b4d56af955efd7e7dce06ee48) PM-7366 Implemented cipher selection on search on passkey creation - [`e652b9b`](https://github.com/bitwarden/android/commit/e652b9bd4f31af8a8d8408ce8cb0004dca39b7e1) PM-7366 Fix typo ### 📊 Changes **5 files changed** (+53 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs` (+21 -2) 📝 `src/App/Platforms/Android/MainApplication.cs` (+2 -1) 📝 `src/Core/Abstractions/IFido2MakeCredentialConfirmationUserInterface.cs` (+17 -1) 📝 `src/Core/Pages/Vault/AutofillCiphersPageViewModel.cs` (+1 -17) 📝 `src/Core/Pages/Vault/CiphersPageViewModel.cs` (+12 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implemented cipher selection on search on Fido2 creation ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Fido2MakeCredentialUserInterface:** Moved logic of cipher selection check to create a Fido2 credential here in order to be reused between cipher list and search. * **CiphersPageViewModel:** Added call to the aforementioned UserInterface to select a cipher for Fido2 creation ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:12:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?