github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4803] [MERGED] [PM-17739] Show password history #5225

New Issue
Closed
opened 2025-11-26 23:55:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4803
Author: @andrebispo5
Created: 2/27/2025
Status: ✅ Merged
Merged: 2/27/2025
Merged by: @andrebispo5

Base: main ← Head: pm-17739/show_password_history

📝 Commits (8)

  • f4ca611 [PM-17739] Move password history to other item types
  • a66d87d [PM-17739] Update tests
  • 6c35be3 [PM-17739] Add password revision date label.
  • dc2207c [PM-17739] Update tests
  • 758e9e1 Revert "[PM-17739] Add password revision date label."
  • 2ea2c55 Revert "[PM-17739] Update tests"
  • 97c2c2e Merge branch 'main' into pm-17739/show_password_history
  • 39f3054 [PM-17739] Fix merge

📊 Changes

12 files changed (+320 additions, -66 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt (+23 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt (+23 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt (+2 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt (+21 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSshKeyContent.kt (+22 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+11 -14)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultLoginItemTypeHandlers.kt (+0 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+208 -36)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+3 -3)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt (+2 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17739

📔 Objective

Currently password history is only being shown for the login item type.
This PR adds password history to the following types:

  • Secure Notes
  • Cards
  • Identities
  • SSH Keys

📸 Screenshots

https://github.com/user-attachments/assets/ccdcfe30-0ecf-4b9f-9cb8-ffe07189e9ff

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4803 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 2/27/2025 **Status:** ✅ Merged **Merged:** 2/27/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-17739/show_password_history` --- ### 📝 Commits (8) - [`f4ca611`](https://github.com/bitwarden/android/commit/f4ca611da4eda71bed9db8010859e7eb0602b8ba) [PM-17739] Move password history to other item types - [`a66d87d`](https://github.com/bitwarden/android/commit/a66d87d053b7db2257846e1f6e4c67221db2eba5) [PM-17739] Update tests - [`6c35be3`](https://github.com/bitwarden/android/commit/6c35be3ba10f47855ab13c186a5b81e736723d12) [PM-17739] Add password revision date label. - [`dc2207c`](https://github.com/bitwarden/android/commit/dc2207c98ef7d025c4932e100de07824041aa658) [PM-17739] Update tests - [`758e9e1`](https://github.com/bitwarden/android/commit/758e9e1e2be820f093136e41c4269de96e1ef0d9) Revert "[PM-17739] Add password revision date label." - [`2ea2c55`](https://github.com/bitwarden/android/commit/2ea2c555fcb39ac9f297960e16697e1fd4016f28) Revert "[PM-17739] Update tests" - [`97c2c2e`](https://github.com/bitwarden/android/commit/97c2c2ea0f9e3a584f7327104a92873a957a7802) Merge branch 'main' into pm-17739/show_password_history - [`39f3054`](https://github.com/bitwarden/android/commit/39f3054467ea363460762ffd10f88836aa9324b8) [PM-17739] Fix merge ### 📊 Changes **12 files changed** (+320 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt` (+23 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt` (+23 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt` (+2 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt` (+21 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSshKeyContent.kt` (+22 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+11 -14) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultLoginItemTypeHandlers.kt` (+0 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+208 -36) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+3 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt` (+2 -1) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-17739 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Currently **password history** is only being shown for the **login item** type. This PR adds **password history** to the following types: - Secure Notes - Cards - Identities - SSH Keys ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> https://github.com/user-attachments/assets/ccdcfe30-0ecf-4b9f-9cb8-ffe07189e9ff ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5225
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?