github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4797] [MERGED] 🍒 PM-18636 Hide coach mark card if any login ciphers exist #5221

New Issue
Closed
opened 2025-11-26 23:55:49 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:49 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4797
Author: @phil-livefront
Created: 2/26/2025
Status: ✅ Merged
Merged: 2/26/2025
Merged by: @phil-livefront

Base: release/2025.02-rc16 ← Head: phil/PM-18636-cherry-pick-to-rc

📝 Commits (1)

  • 8e9d23f PM-18636 Hide coach mark card if any login ciphers exist (#4787)

📊 Changes

2 files changed (+87 additions, -5 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt (+21 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt (+66 -5)

📄 Description

🎟️ Tracking

PM-18636

📔 Objective

This is a cherry pick from this PR to the release branch
Notes from PR:

  • To avoid showing the coach mark cards to users who have been using the app and are familiar we are adding a business rule to avoid showing the card if there is any LOGIN type ciphers in the user's vault.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4797 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 2/26/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `release/2025.02-rc16` ← **Head:** `phil/PM-18636-cherry-pick-to-rc` --- ### 📝 Commits (1) - [`8e9d23f`](https://github.com/bitwarden/android/commit/8e9d23fa42d4f9743a99896364b83dc2ac328410) PM-18636 Hide coach mark card if any login ciphers exist (#4787) ### 📊 Changes **2 files changed** (+87 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt` (+21 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt` (+66 -5) </details> ### 📄 Description ## 🎟️ Tracking [PM-18636](https://bitwarden.atlassian.net/browse/PM-18636) ## 📔 Objective This is a cherry pick from this [PR](https://github.com/bitwarden/android/pull/4787) to the release branch Notes from PR: - To avoid showing the coach mark cards to users who have been using the app and are familiar we are adding a business rule to avoid showing the card if there is any LOGIN type ciphers in the user's vault. - ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18636]: https://bitwarden.atlassian.net/browse/PM-18636?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:49 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5221
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?