github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4790] [MERGED] [PM-8223] new device verification ux improvements RC #5215

New Issue
Closed
opened 2025-11-26 23:55:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4790
Author: @aj-rosado
Created: 2/26/2025
Status: ✅ Merged
Merged: 2/27/2025
Merged by: @aj-rosado

Base: release/2025.02-rc16 ← Head: PM-8223/new-device-verification-ux-improvements-rc

📝 Commits (3)

  • 3de202b Changed error string when invalid code to always use the localized
  • a327aec Moved suppress MagicNumber to the line above the number
  • a9c9be7 Revert errorMessage ignore change

📊 Changes

2 files changed (+30 additions, -1 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt (+3 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt (+27 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8223

📔 Objective

PR to RC of https://github.com/bitwarden/android/pull/4772

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4790 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 2/26/2025 **Status:** ✅ Merged **Merged:** 2/27/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `release/2025.02-rc16` ← **Head:** `PM-8223/new-device-verification-ux-improvements-rc` --- ### 📝 Commits (3) - [`3de202b`](https://github.com/bitwarden/android/commit/3de202b63955cb251f2c99e983880d5683cc04b4) Changed error string when invalid code to always use the localized - [`a327aec`](https://github.com/bitwarden/android/commit/a327aecdfc1563d96dbe97a12089b02263da8c71) Moved suppress MagicNumber to the line above the number - [`a9c9be7`](https://github.com/bitwarden/android/commit/a9c9be79415313301bdbda8699a364dcca877c21) Revert errorMessage ignore change ### 📊 Changes **2 files changed** (+30 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt` (+3 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt` (+27 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-8223 ## 📔 Objective PR to RC of https://github.com/bitwarden/android/pull/4772 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5215
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?