github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 05:20:24 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2832] [MERGED] [PM-4404] Add CreationDate to Fido2Credential objects #52049

New Issue
Closed
opened 2026-05-01 15:49:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:49:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2832
Author: @fedemkr
Created: 10/19/2023
Status: ✅ Merged
Merged: 10/19/2023
Merged by: @fedemkr

Base: master ← Head: vault/pm-4404/fix-passkey-creation-time

📝 Commits (1)

  • ca32de0 PM-4404 Added CreationDate to Fido2Credential objects and updated the UI bindings accordingly

📊 Changes

8 files changed (+52 additions, -14 deletions)

View changed files

📝 src/App/Pages/Vault/CipherAddEditPage.xaml (+4 -1)
📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+4 -2)
📝 src/App/Utilities/DateTimeConverter.cs (+3 -1)
📝 src/Core/Models/Api/Fido2CredentialApi.cs (+4 -1)
📝 src/Core/Models/Data/Fido2CredentialData.cs (+4 -1)
📝 src/Core/Models/Domain/Fido2Credential.cs (+15 -5)
📝 src/Core/Models/View/Fido2CredentialView.cs (+13 -1)
📝 src/Core/Services/CipherService.cs (+5 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add CreationDate to Fido2Credential objects and update the UI accordingly also fixing an issue where the date time was not being presented in local time.

Code changes

  • Fido2Credential...: Added CreationDate and updated mappings.
  • ...Page.xaml: Updated bindings to the new creation date and use DateTimeConverter with the specific format to avoid creating a new property on the VMs.
  • DateTimeConverter: Added Format property with a default value so we can customize it in specific occasions like this one.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2832 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 10/19/2023 **Status:** ✅ Merged **Merged:** 10/19/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/pm-4404/fix-passkey-creation-time` --- ### 📝 Commits (1) - [`ca32de0`](https://github.com/bitwarden/android/commit/ca32de097c000430d2912a865756d2d1b840a490) PM-4404 Added CreationDate to Fido2Credential objects and updated the UI bindings accordingly ### 📊 Changes **8 files changed** (+52 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherAddEditPage.xaml` (+4 -1) 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+4 -2) 📝 `src/App/Utilities/DateTimeConverter.cs` (+3 -1) 📝 `src/Core/Models/Api/Fido2CredentialApi.cs` (+4 -1) 📝 `src/Core/Models/Data/Fido2CredentialData.cs` (+4 -1) 📝 `src/Core/Models/Domain/Fido2Credential.cs` (+15 -5) 📝 `src/Core/Models/View/Fido2CredentialView.cs` (+13 -1) 📝 `src/Core/Services/CipherService.cs` (+5 -2) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add `CreationDate` to `Fido2Credential` objects and update the UI accordingly also fixing an issue where the date time was not being presented in local time. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Fido2Credential...:** Added `CreationDate` and updated mappings. * **...Page.xaml:** Updated bindings to the new creation date and use `DateTimeConverter` with the specific format to avoid creating a new property on the VMs. * **DateTimeConverter:** Added `Format` property with a default value so we can customize it in specific occasions like this one. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:49:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52049
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?