github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2737] [MERGED] [PM-3693] Clear old Settings approach #51995

New Issue
Closed
opened 2026-05-01 15:44:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:44:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2737
Author: @fedemkr
Created: 8/29/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @fedemkr

Base: vault/pm-2658/feature-settings-reorganization ← Head: vault/pm-3693/clear-old-settings

📝 Commits (5)

  • 9b6bf10 PM-3511 Implemented autofill settings view
  • 3a942d7 Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3511/settings-autofill
  • 086159f PM-3693 Remove old Settings approach
  • 8e6a5a5 Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3693/clear-old-settings
  • 1fb459c Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3693/clear-old-settings

📊 Changes

19 files changed (+5 additions, -2370 deletions)

View changed files

📝 src/App/App.csproj (+0 -9)
➖ src/App/Pages/Settings/AutofillServicesPage.xaml (+0 -131)
➖ src/App/Pages/Settings/AutofillServicesPage.xaml.cs (+0 -66)
➖ src/App/Pages/Settings/AutofillServicesPageViewModel.cs (+0 -231)
➖ src/App/Pages/Settings/OptionsPage.xaml (+0 -169)
➖ src/App/Pages/Settings/OptionsPage.xaml.cs (+0 -53)
➖ src/App/Pages/Settings/OptionsPageViewModel.cs (+0 -300)
➖ src/App/Pages/Settings/SettingsPage/ISettingsPageListItem.cs (+0 -6)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml (+0 -111)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs (+3 -73)
➖ src/App/Pages/Settings/SettingsPage/SettingsPageHeaderListItem.cs (+0 -12)
➖ src/App/Pages/Settings/SettingsPage/SettingsPageListGroup.cs (+0 -29)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageListItem.cs (+1 -46)
➖ src/App/Pages/Settings/SettingsPage/SettingsPageListItemSelector.cs (+0 -24)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+1 -895)
➖ src/App/Pages/Settings/SyncPage.xaml (+0 -51)
➖ src/App/Pages/Settings/SyncPage.xaml.cs (+0 -43)
➖ src/App/Pages/Settings/SyncPageViewModel.cs (+0 -117)
📝 src/App/Pages/TabsPage.cs (+0 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Clear old settings approach code.

Code changes

  • Removed old settings code and related stuff.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2737 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 8/29/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `vault/pm-2658/feature-settings-reorganization` ← **Head:** `vault/pm-3693/clear-old-settings` --- ### 📝 Commits (5) - [`9b6bf10`](https://github.com/bitwarden/android/commit/9b6bf1009b550459d413f2f2fa4a99c28a9c71c3) PM-3511 Implemented autofill settings view - [`3a942d7`](https://github.com/bitwarden/android/commit/3a942d75156a8c6bfb67861ec2e8fbb8c7c058a8) Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3511/settings-autofill - [`086159f`](https://github.com/bitwarden/android/commit/086159f177acbd5ee6bca73d82b1e72e57aab874) PM-3693 Remove old Settings approach - [`8e6a5a5`](https://github.com/bitwarden/android/commit/8e6a5a52ff4fec3623bf6db7b8b445462376957e) Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3693/clear-old-settings - [`1fb459c`](https://github.com/bitwarden/android/commit/1fb459c8e9d03b34163ec68b7b15d341f300f1be) Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3693/clear-old-settings ### 📊 Changes **19 files changed** (+5 additions, -2370 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+0 -9) ➖ `src/App/Pages/Settings/AutofillServicesPage.xaml` (+0 -131) ➖ `src/App/Pages/Settings/AutofillServicesPage.xaml.cs` (+0 -66) ➖ `src/App/Pages/Settings/AutofillServicesPageViewModel.cs` (+0 -231) ➖ `src/App/Pages/Settings/OptionsPage.xaml` (+0 -169) ➖ `src/App/Pages/Settings/OptionsPage.xaml.cs` (+0 -53) ➖ `src/App/Pages/Settings/OptionsPageViewModel.cs` (+0 -300) ➖ `src/App/Pages/Settings/SettingsPage/ISettingsPageListItem.cs` (+0 -6) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml` (+0 -111) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs` (+3 -73) ➖ `src/App/Pages/Settings/SettingsPage/SettingsPageHeaderListItem.cs` (+0 -12) ➖ `src/App/Pages/Settings/SettingsPage/SettingsPageListGroup.cs` (+0 -29) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageListItem.cs` (+1 -46) ➖ `src/App/Pages/Settings/SettingsPage/SettingsPageListItemSelector.cs` (+0 -24) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+1 -895) ➖ `src/App/Pages/Settings/SyncPage.xaml` (+0 -51) ➖ `src/App/Pages/Settings/SyncPage.xaml.cs` (+0 -43) ➖ `src/App/Pages/Settings/SyncPageViewModel.cs` (+0 -117) 📝 `src/App/Pages/TabsPage.cs` (+0 -4) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Clear old settings approach code. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * Removed old settings code and related stuff. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:44:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?