github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4771] [CLOSED] Test PR #5198

New Issue
Closed
opened 2025-11-26 23:55:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4771
Author: @vvolkgang
Created: 2/24/2025
Status: ❌ Closed

Base: main ← Head: test-bwa

📝 Commits (5)

📊 Changes

471 files changed (+42041 additions, -26 deletions)

View changed files

📝 .github/workflows/build-authenticator.yml (+274 -4)
📝 .github/workflows/crowdin-pull-authenticator.yml (+47 -5)
📝 .github/workflows/crowdin-push-authenticator.yml (+22 -5)
📝 .github/workflows/scan-authenticator.yml (+67 -4)
📝 .github/workflows/test-authenticator.yml (+75 -4)
➕ authenticator/build.gradle.kts (+331 -0)
➕ authenticator/libs/authenticatorbridge-1.0.0-release.aar (+0 -0)
➕ authenticator/proguard-rules.pro (+112 -0)
➕ authenticator/schemas/com.bitwarden.authenticator.data.authenticator.datasource.disk.database.AuthenticatorDatabase/1.json (+82 -0)
➕ authenticator/schemas/com.bitwarden.authenticator.data.authenticator.datasource.disk.database.AuthenticatorDatabase/2.json (+89 -0)
➕ authenticator/src/androidTest/kotlin/com/x8bit/bitwarden/android/authenticator/ExampleInstrumentedTest.kt (+137 -0)
➕ authenticator/src/debug/AndroidManifest.xml (+20 -0)
➕ authenticator/src/debug/google-services.json (+29 -0)
➕ authenticator/src/google-services.json (+29 -0)
➕ authenticator/src/main/AndroidManifest.xml (+60 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/AuthenticatorApplication.kt (+18 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/MainActivity.kt (+121 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/MainViewModel.kt (+142 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/data/auth/datasource/disk/AuthDiskSource.kt (+38 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/data/auth/datasource/disk/AuthDiskSourceImpl.kt (+56 -0)

...and 80 more files

📄 Description

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4771 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 2/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test-bwa` --- ### 📝 Commits (5) - [`dbf4921`](https://github.com/bitwarden/android/commit/dbf4921b73ddd245a0530a74db4b948002185fc9) bitwarden/authenticator-android@1777ed3e61367e47e75772589cb88027ea10c7a2 - [`76d4ed1`](https://github.com/bitwarden/android/commit/76d4ed1e964b041407246d2209ff0ead0a65ce73) Merged Fastfile - [`b1bb021`](https://github.com/bitwarden/android/commit/b1bb021db92c3ac69b22f690a319c410a542f98e) Added authenticator to settings.gradle.kts - [`a3f147a`](https://github.com/bitwarden/android/commit/a3f147aaab0fbdfa30956e5cc334a6f0653d9fd6) Merged libs.version.toml - [`6ba34b0`](https://github.com/bitwarden/android/commit/6ba34b0921b82b6a28d8f158982c16ac01b963d8) Update secrets name ### 📊 Changes **471 files changed** (+42041 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-authenticator.yml` (+274 -4) 📝 `.github/workflows/crowdin-pull-authenticator.yml` (+47 -5) 📝 `.github/workflows/crowdin-push-authenticator.yml` (+22 -5) 📝 `.github/workflows/scan-authenticator.yml` (+67 -4) 📝 `.github/workflows/test-authenticator.yml` (+75 -4) ➕ `authenticator/build.gradle.kts` (+331 -0) ➕ `authenticator/libs/authenticatorbridge-1.0.0-release.aar` (+0 -0) ➕ `authenticator/proguard-rules.pro` (+112 -0) ➕ `authenticator/schemas/com.bitwarden.authenticator.data.authenticator.datasource.disk.database.AuthenticatorDatabase/1.json` (+82 -0) ➕ `authenticator/schemas/com.bitwarden.authenticator.data.authenticator.datasource.disk.database.AuthenticatorDatabase/2.json` (+89 -0) ➕ `authenticator/src/androidTest/kotlin/com/x8bit/bitwarden/android/authenticator/ExampleInstrumentedTest.kt` (+137 -0) ➕ `authenticator/src/debug/AndroidManifest.xml` (+20 -0) ➕ `authenticator/src/debug/google-services.json` (+29 -0) ➕ `authenticator/src/google-services.json` (+29 -0) ➕ `authenticator/src/main/AndroidManifest.xml` (+60 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/AuthenticatorApplication.kt` (+18 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/MainActivity.kt` (+121 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/MainViewModel.kt` (+142 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/auth/datasource/disk/AuthDiskSource.kt` (+38 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/auth/datasource/disk/AuthDiskSourceImpl.kt` (+56 -0) _...and 80 more files_ </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5198
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?