github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2647] [MERGED] [PM-3165] Fix custom block URI dialog cancellation #51920

New Issue
Closed
opened 2026-05-01 15:38:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:38:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2647
Author: @fedemkr
Created: 7/27/2023
Status: ✅ Merged
Merged: 7/27/2023
Merged by: @fedemkr

Base: master ← Head: vault/pm-3165/fix-finish-task-on-cancel-dialog

📝 Commits (1)

  • 2c3eb51 PM-3165 Finish task completion source when cancelling the dialog tapping on the background.

📊 Changes

1 file changed (+17 additions, -6 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+17 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix custom block URI dialog cancellation to finish its internal task and not block the button.

Code changes

  • DeviceActionService: Added BasicDialogWithResultCancelListener to handle dialog cancellation and set the return task value to null so that the task gets finished when the user taps in the background to cancel the opened dialog.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2647 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/27/2023 **Status:** ✅ Merged **Merged:** 7/27/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/pm-3165/fix-finish-task-on-cancel-dialog` --- ### 📝 Commits (1) - [`2c3eb51`](https://github.com/bitwarden/android/commit/2c3eb51b4dd96a2139c6bf3a121ff2cab3b49b5e) PM-3165 Finish task completion source when cancelling the dialog tapping on the background. ### 📊 Changes **1 file changed** (+17 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+17 -6) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix custom block URI dialog cancellation to finish its internal task and not block the button. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **DeviceActionService:** Added `BasicDialogWithResultCancelListener` to handle dialog cancellation and set the return task value to `null` so that the task gets finished when the user taps in the background to cancel the opened dialog. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:38:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51920
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?