github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4763] [MERGED] PM-18129 add authenticator illustration for 2fa screen #5192

New Issue
Closed
opened 2025-11-26 23:55:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4763
Author: @dseverns-livefront
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/24/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-18129-2fa-auth-illustration

📝 Commits (1)

  • 6f4b74d PM-18129 add authenticator illustration for 2fa screen

📊 Changes

5 files changed (+146 additions, -4 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/util/TwoFactorAuthMethodExtensions.kt (+1 -0)
➕ app/src/main/res/drawable-night/img_authenticator.xml (+68 -0)
➕ app/src/main/res/drawable/img_authenticator.xml (+73 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/util/TwoFactorAuthMethodExtensionTest.kt (+1 -1)

📄 Description

🎟️ Tracking

PM-18129

📔 Objective

  • Adds illustration for the Authenticator on the 2fa screen.
  • Corrects some logic so only the Yubi key image is below the description (prior to this change there was only 2 images so just flipped the boolean a bit to make it work generically).
  • Updates image size to match figma for email and authenticator images on that screen.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4763 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-18129-2fa-auth-illustration` --- ### 📝 Commits (1) - [`6f4b74d`](https://github.com/bitwarden/android/commit/6f4b74dbfaec49af30c61e35390798af7258f3f2) PM-18129 add authenticator illustration for 2fa screen ### 📊 Changes **5 files changed** (+146 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/util/TwoFactorAuthMethodExtensions.kt` (+1 -0) ➕ `app/src/main/res/drawable-night/img_authenticator.xml` (+68 -0) ➕ `app/src/main/res/drawable/img_authenticator.xml` (+73 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/util/TwoFactorAuthMethodExtensionTest.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-18129](https://bitwarden.atlassian.net/browse/PM-18129) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Adds illustration for the Authenticator on the 2fa screen. - Corrects some logic so only the Yubi key image is below the description (prior to this change there was only 2 images so just flipped the boolean a bit to make it work generically). - Updates image size to match figma for email and authenticator images on that screen. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots ![image](https://github.com/user-attachments/assets/809861ca-e1bc-4610-a5b5-0bb6d1dd1720) <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18129]: https://bitwarden.atlassian.net/browse/PM-18129?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5192
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?