github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2609] [MERGED] [PM-2583] Add logic to only send Symmetric Key for TDE Approval Auth Request #51893

New Issue
Closed
opened 2026-05-01 15:36:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:36:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2609
Author: @andrebispo5
Created: 7/10/2023
Status: ✅ Merged
Merged: 7/11/2023
Merged by: @andrebispo5

Base: feature/pm-1029-tde-login ← Head: feature/pm-2583-symkey

📝 Commits (1)

  • de7be28 [PM-2583] Answer auth request with mp field as null if doesn't have it.

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 src/Core/Services/AuthService.cs (+7 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

On the approving device, we should only be sending the encrypted Symmetric Key since we have already authenticated through SSO.

Code changes

if mp is not present ignore it and send null.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2609 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 7/10/2023 **Status:** ✅ Merged **Merged:** 7/11/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/pm-1029-tde-login` ← **Head:** `feature/pm-2583-symkey` --- ### 📝 Commits (1) - [`de7be28`](https://github.com/bitwarden/android/commit/de7be28e0b3d04ff76d2c047455db1133a488a0b) [PM-2583] Answer auth request with mp field as null if doesn't have it. ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/AuthService.cs` (+7 -2) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> On the approving device, we should only be sending the encrypted Symmetric Key since we have already authenticated through SSO. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> if mp is not present ignore it and send null. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:36:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51893
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?