github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-11-10 01:15:13 -06:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2593] [MERGED] [PM-1063] Re-prompt for Master Password Can be Bypassed When Using Gboard Inline Autofill #51883

New Issue
Closed
opened 2026-05-01 15:35:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 15:35:50 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2593
Author: @cagonzalezcs
Created: 6/29/2023
Status: ✅ Merged
Merged: 7/11/2023
Merged by: @cagonzalezcs

Base: master ← Head: Client-Integrations/pm-1063-master-password-reprompt-bypass-when-gboard-inline-autofill

📝 Commits (3)

  • 342bfb0 [PM-1063] Re-prompt for Master Password Can be Bypassed When Using Gboard Inline Autofill
  • f79bc25 Merge branch 'master' into Client-Integrations/pm-1063-master-password-reprompt-bypass-when-gboard-inline-autofill
  • 4693529 Merge branch 'master' into Client-Integrations/pm-1063-master-password-reprompt-bypass-when-gboard-inline-autofill

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+5 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

An issue has been identified that allows users to bypass the master password re-prompt on vault items that require a re-prompt within Android. If a user has opted to allow inline autofill, they can use the filter feature to find the item they are attempting to autofill, and select "Autofill" from that list of items to bypass the required re-prompt.

This code change adds a check shortly after selecting "Autofill" or "Autofill and Save", checking if the cipher requires a re-prompt, and forcing the user to enter the password before the autofill occurs.

Code changes

  • src/App/Pages/Vault/CiphersPageViewModel.cs: Added a conditional check within theSelectCipherAsync method that identifies if a master password re-prompt is required. If not, then the autofill occurs as expected. If so, then we prompt the user for the master password before autofilling.

Screenshots

https://github.com/bitwarden/mobile/assets/16629865/58add0b9-22ed-4f78-9ebf-32818bc7361f

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2593 **Author:** [@cagonzalezcs](https://github.com/cagonzalezcs) **Created:** 6/29/2023 **Status:** ✅ Merged **Merged:** 7/11/2023 **Merged by:** [@cagonzalezcs](https://github.com/cagonzalezcs) **Base:** `master` ← **Head:** `Client-Integrations/pm-1063-master-password-reprompt-bypass-when-gboard-inline-autofill` --- ### 📝 Commits (3) - [`342bfb0`](https://github.com/bitwarden/android/commit/342bfb02dace82fa0ab2f84708342b1540867475) [PM-1063] Re-prompt for Master Password Can be Bypassed When Using Gboard Inline Autofill - [`f79bc25`](https://github.com/bitwarden/android/commit/f79bc2546df3ed8261de2dfecbe8f76ef3ff50fa) Merge branch 'master' into Client-Integrations/pm-1063-master-password-reprompt-bypass-when-gboard-inline-autofill - [`4693529`](https://github.com/bitwarden/android/commit/4693529b78d98397a4a7cf532c6e5d81c6572f82) Merge branch 'master' into Client-Integrations/pm-1063-master-password-reprompt-bypass-when-gboard-inline-autofill ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+5 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective An issue has been identified that allows users to bypass the master password re-prompt on vault items that require a re-prompt within Android. If a user has opted to allow inline autofill, they can use the filter feature to find the item they are attempting to autofill, and select "Autofill" from that list of items to bypass the required re-prompt. This code change adds a check shortly after selecting "Autofill" or "Autofill and Save", checking if the cipher requires a re-prompt, and forcing the user to enter the password before the autofill occurs. ## Code changes * **src/App/Pages/Vault/CiphersPageViewModel.cs:** Added a conditional check within the`SelectCipherAsync` method that identifies if a master password re-prompt is required. If not, then the autofill occurs as expected. If so, then we prompt the user for the master password before autofilling. ## Screenshots https://github.com/bitwarden/mobile/assets/16629865/58add0b9-22ed-4f78-9ebf-32818bc7361f --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 15:35:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#51883