github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 04:33:30 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4758] [MERGED] PM-18315 add UI when 3pa is available for each chrome channel which s… #5187

New Issue
Closed
opened 2025-11-26 23:55:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:55:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4758
Author: @dseverns-livefront
Created: 2/20/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-18315-ui-and-intent-to-chrome

📝 Commits (3)

  • 5ce6fa6 PM-18315 add UI when 3pa is available for each chrome channel which shows if its enabled and take user to the settings for that version when clicked
  • 7d75bc2 Pr feedback
  • 4e54b38 touchup

📊 Changes

9 files changed (+412 additions, -6 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt (+21 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModel.kt (+72 -3)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/chrome/ChromeAutofillSettingsCard.kt (+94 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/chrome/model/ChromeAutofillSettingsOption.kt (+42 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt (+17 -0)
📝 app/src/main/res/values/strings.xml (+3 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt (+83 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModelTest.kt (+74 -1)

📄 Description

🎟️ Tracking

PM-18315

📔 Objective

  • Display a card with all the available Chrome 3P autofill options and if 3PA is enabled or not.
  • When an option is clicked, take the user the Autofill settings for that version of Chrome to update their 3rd party autofill status.
  • Options are disabled if BW is not set as the system's Autofill service.
  • Note currently need to install the Beta version of Chrome to see this.

📸 Screenshots

If you are patient through my struggle to delete the Chrome beta, shows that if there is no Chrome app installed supporting 3PA the card does not show.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4758 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 2/20/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-18315-ui-and-intent-to-chrome` --- ### 📝 Commits (3) - [`5ce6fa6`](https://github.com/bitwarden/android/commit/5ce6fa60f74cedc22b7a2a27adb08dbb30ed6b29) PM-18315 add UI when 3pa is available for each chrome channel which shows if its enabled and take user to the settings for that version when clicked - [`7d75bc2`](https://github.com/bitwarden/android/commit/7d75bc207abe9021c548959cbac152884e0f1c73) Pr feedback - [`4e54b38`](https://github.com/bitwarden/android/commit/4e54b3818afa660ec05e166d55f5e10774e4a191) touchup ### 📊 Changes **9 files changed** (+412 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt` (+21 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModel.kt` (+72 -3) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/chrome/ChromeAutofillSettingsCard.kt` (+94 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/chrome/model/ChromeAutofillSettingsOption.kt` (+42 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt` (+17 -0) 📝 `app/src/main/res/values/strings.xml` (+3 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt` (+83 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModelTest.kt` (+74 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-18315](https://bitwarden.atlassian.net/browse/PM-18315) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Display a card with all the available Chrome 3P autofill options and if 3PA is enabled or not. - When an option is clicked, take the user the Autofill settings for that version of Chrome to update their 3rd party autofill status. - Options are disabled if BW is not set as the system's Autofill service. - **Note** currently need to install the Beta version of Chrome to see this. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots _If you are patient through my struggle to delete the Chrome beta, shows that if there is no Chrome app installed supporting 3PA the card does not show._ <video src="https://github.com/user-attachments/assets/ffcb70f7-a5c9-459f-9a0d-41ac17480446" width="300" /> <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18315]: https://bitwarden.atlassian.net/browse/PM-18315?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:55:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5187
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?